Merge pull request #1656 from flix-tech/asg-tags-resource-override #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
szuecs
reviewed
Jan 10, 2020
szuecs
reviewed
Jan 10, 2020
|
@szuecs, this is a cherry-pick of kubernetes#1656 so not really "my" code |
|
@muaazsaleem I think you cherry-picked the "wrong" commit which is the merge commit. It doesn't correctly attribute the original author. This would be the correct commit: kubernetes@f79a432 |
muaazsaleem
force-pushed
the
ephemeral-storage
branch
from
486f733 to
019e615
Compare
|
@mikkeloscar thanks for the catch. Pushed the correct commit. |
…ubernetes#1650 # Conflicts: # cluster-autoscaler/cloudprovider/aws/aws_manager.go # cluster-autoscaler/cloudprovider/aws/aws_manager_test.go
muaazsaleem
force-pushed
the
ephemeral-storage
branch
from
019e615 to
5c05916
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding ability to override allocatable resources via ASG tags.