Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Drop for Blink adapter #5

Merged
merged 4 commits into from
Mar 3, 2024
Merged

Conversation

dmitry-salin
Copy link

Blink adapter docs contains:

/// [`Blink`] calls [`Drop::drop`] for emplaced values when reset or dropped.

But in fact it only does this when reset.

@zakarumych
Copy link
Owner

Thanks for noticing this!

@dmitry-salin
Copy link
Author

Thanks for quick response. It seems I needed to apply fmt to the entire project. Also clippy with --all-features flag is failing on stable.

@zakarumych
Copy link
Owner

Yeah, they change set of lints and it's typical for check to fail after some time.
If it's not too much, please, add clippy fixes.

@dmitry-salin
Copy link
Author

actions-rs is no longer maintained. One issue affecting this PR: clippy-check error. I suggest switching to actions-rust-lang and clippy-action.

@zakarumych
Copy link
Owner

Looks great!

@zakarumych zakarumych merged commit 845b2db into zakarumych:main Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants