Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite scrolling support! #15

Closed
wants to merge 3 commits into from
Closed

Conversation

tordo
Copy link

@tordo tordo commented May 17, 2012

Hi!
Don't know if this is ready for mainline yet (haven't tested it in detail), but at least it appears to work.
It's an Alpha feature, and is marked as such in the menu. Anyways, you can take a look and see if you like it :)

Signed-off-by: Tord Øygard [email protected]

tordo added 2 commits May 17, 2012 15:14
Signed-off-by: Tord Øygard <[email protected]>
Signed-off-by: Tord Øygard <[email protected]>
@tordo
Copy link
Author

tordo commented May 17, 2012

I myself have three concerns about the current implementation:

  1. Correctness:
    Although I'm fairly certain, I'm not sure if all posts will actually be seen, or if something might get lost in the corner cases. It uses the same mechanism as the 'next' button
  2. Scrolling performance
    The onScroll listener is called very, very often when scrolling. Ideally we'd hook this up into some onOverScroll listener, but to do that we have to subclass the ListView. Which should be very doable, but I'm feeling lazy right now.
  3. UI:
    What do do with the next/prev buttons?

we're actually supposed to trigger a refresh - don't want to set a lock unless
we have to.

Signed-off-by: Tord Øygard <[email protected]>
@shobhitg
Copy link

I think we should really have infinite scrolling (by default, not even as an option). I really despise clicking next.
Can we do this Tordo? If you would not like to revisit this, then let me know. I will borrow your changes and try make it happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants