cram/record/builder: Deprecate add methods

Use the setters instead.
zaeleus · Oct 23, 2023 · edee012 · edee012
1 parent 3fe2301
commit edee012
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/noodles-cram/CHANGELOG.md b/noodles-cram/CHANGELOG.md
@@ -1,5 +1,15 @@
 # Changelog
 
+## Unreleased
+
+### Deprecated
+
+  * cram/record/builder Deprecate add methods: `Builder::add_tag`,
+    `Builder::add_base`, `Builder::add_feature`, and
+    `Builder::add_quality_score`.
+
+    Use the setters instead.
+
 ## 0.46.0 - 2023-10-23
 
 ### Changed

diff --git a/noodles-cram/src/record/builder.rs b/noodles-cram/src/record/builder.rs
@@ -114,6 +114,7 @@ impl Builder {
     }
 
     /// Adds a tag to the tag dictionary.
+    #[deprecated(since = "0.47.0", note = "Use `Builder::set_tags` instead.")]
     pub fn add_tag(
         mut self,
         tag: sam::record::data::field::Tag,
@@ -130,6 +131,7 @@ impl Builder {
     }
 
     /// Adds a base to the read bases.
+    #[deprecated(since = "0.47.0", note = "Use `Builder::set_bases` instead.")]
     pub fn add_base(mut self, base: Base) -> Self {
         self.bases.push(base);
         self
@@ -142,6 +144,7 @@ impl Builder {
     }
 
     /// Adds a read feature.
+    #[deprecated(since = "0.47.0", note = "Use `Builder::set_features` instead.")]
     pub fn add_feature(mut self, feature: Feature) -> Self {
         self.features.push(feature);
         self
@@ -160,6 +163,7 @@ impl Builder {
     }
 
     /// Adds a quality score.
+    #[deprecated(since = "0.47.0", note = "Use `Builder::set_quality_scores` instead.")]
     pub fn add_quality_score(mut self, score: u8) -> Self {
         self.quality_scores.as_mut().push(score);
         self