Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable git repository root #53

Merged
merged 5 commits into from
Jun 2, 2022

Conversation

frankdugan3
Copy link
Contributor

Contributor checklist

  • [ x ] My commit messages follow the Conventional Commit Message Format
    For example: fix: Multiply by appropriate coefficient, or
    feat(Calculator): Correctly preserve history
    Any explanation or long form information in your commit message should be
    in a separate paragraph, separated by a blank line from the primary message
  • [ x ] Bug fixes include regression tests
  • [ x ] Features include unit/acceptance tests (partial!)

I tried to organize my commits neatly, there's clear separation of chores along the way and the feature itself.

No tests are broken, and I added one test to check for the default repo value of cwd. I'm not sure how to test for the custom git repo, so I'm thinking for now this can be a "here be dragons" feature. I did not add documentation for this reason as well, but would be happy to do so if you think that's a good idea.

I did test this on one of my poncho/nerves projects and it seems to be working correctly.

As always, open to nitpicking/refactoring.

Closes: #52
Closes: #37

Copy link
Owner

@zachdaniel zachdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, had a couple questions that may need addressing, but otherwise awesome!

lib/git_ops/git.ex Show resolved Hide resolved
lib/mix/tasks/git_ops.release.ex Show resolved Hide resolved
@zachdaniel
Copy link
Owner

🚀 Thank you for your contribution! 🚀

@zachdaniel zachdaniel merged commit c2792bb into zachdaniel:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Path for .git folder Is it possible for git_ops to work with elixir app in a subdirectory?
2 participants