fix: raise error if file_name is nil

fix: raise if non-200 response
zaben903 · Oct 20, 2022 · 87468eb · 87468eb
1 parent 3bfbb79
commit 87468eb
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/lib/puppet/functions/checkmk/get_agent_package.rb b/lib/puppet/functions/checkmk/get_agent_package.rb
@@ -70,7 +70,12 @@ def version_different?(url, bearer_token, site_name, os_type)
     file_name = ''
     Net::HTTP.start(uri.hostname, uri.port) do |http|
       http.request(request) do |response|
-        file_name = response['content-disposition'][%r{filename="(.*)"\Z}, 1]
+        case response.code
+        when '200'
+          file_name = response['content-disposition'][%r{filename="(.*)"\Z}, 1]
+        else
+          raise Puppet::Error, "Failed to check agent package version: { type: #{response.class}, code: #{response.code}, body: #{response.body} }"
+        end
       end
     end