Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matf/stop-overwriting-state-on-empty-state #53

Conversation

shopmatfournier
Copy link
Contributor

closes #52

  • if the state message is empty (that is, no state message was processed) then do not attempt to write the state as this can overwrite state in the event a tap produces no records (or no state message)

- if the state message is empty (that is, no state message was
  processed) then do not attempt to write the state as this can
  overwrite state in the event a tap produces no records (or no state
  message)
@z3z1ma z3z1ma merged commit 831623e into z3z1ma:main Jun 8, 2023
@firehist
Copy link
Contributor

firehist commented Jul 21, 2023

Hello there,

Thanks for the job.
I spotted the same behavior, and I use the latest released version with commit sha 3952428bb043d1db80250e1f11cbcad9c8b18ecd

When it runs without data coming from extractors, it write into the stage empty stage, which make a full run next time.

Do you guys have any suggestions?

Also in Meltano slack : https://meltano.slack.com/archives/C01TCRBBJD7/p1689942408136719

@aminebeh
Copy link

aminebeh commented Jul 21, 2023

Hi, I have encoutered the same behavior as @firehist.

Just wanted to know if it's intended behavior (that should be handled with the right config) or an oversight ?

Thanks in advance for your work 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

target overwrites state if no state message is sent
6 participants