Skip to content

Commit

Permalink
Leave a note about a commented out panic.
Browse files Browse the repository at this point in the history
  • Loading branch information
msolo committed Jan 27, 2019
1 parent 8ece017 commit 1a1ad7f
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions zk/conn.go
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,11 @@ func (c *Conn) sendEvent(evt Event) {
select {
case c.eventChan <- evt:
default:
// NOTE(msolo) It is assumed that the caller of Connect() either
// drains the event channel or is uninterested in session
// events. An undelivered session event it not an error since the
// internal state is still handled correctly.
//
// panic("zk: event channel full - it must be monitored and never allowed to be full")
}
}
Expand Down

0 comments on commit 1a1ad7f

Please sign in to comment.