Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay when deleting text with backspace #181

Closed
songxianpeng opened this issue May 21, 2018 · 11 comments
Closed

Delay when deleting text with backspace #181

songxianpeng opened this issue May 21, 2018 · 11 comments
Labels
Issue: Performance The ability to respond to user actions quickly. Diagnosis requires expertise and detailed info.

Comments

@songxianpeng
Copy link

I've just updated version 1.4.0, and when I use BACKSPACE to delete text, it's a delay, for example when you delete text on a list item
@yzhang-gh
Copy link
Owner

Could you provide some sample text for me to test?

@songxianpeng
Copy link
Author

Here is a sample text, I use Simplified Chinese, in the middle of the document in the center of the list items and then delete text, something will be delayed, because the text is too large?

sample.zip

@yzhang-gh
Copy link
Owner

Reproduced on line 137. Thanks, I'll look into it.

@yzhang-gh
Copy link
Owner

I find it is a vscode issue. Would you mind me reporting this issue to vscode using your sample file?

@songxianpeng
Copy link
Author

I don't mind, thanks for the information provided.

@yzhang-gh yzhang-gh added Upstream Pertaining to an upstream component, or blocked by an upstream issue. and removed Upstream Pertaining to an upstream component, or blocked by an upstream issue. labels May 22, 2018
@yzhang-gh
Copy link
Owner

Are you using vscode insider build? I can reproduce it with insider build v1.24.0, but v1.23.1 works well.

@songxianpeng
Copy link
Author

I'm using version v1.23.1,and there is my vscode version info.
image

This was referenced Jun 5, 2018
Open
Open
@songxianpeng
Copy link
Author

This issue looks much better with the new vscode version 1.24.0.

@yzhang-gh
Copy link
Owner

😂 I don't know why but am happy to hear that.

@yzhang-gh yzhang-gh mentioned this issue Aug 8, 2018
Closed
@lautumn1990
Copy link

文件大的话, 使用backspace删除内容特别卡

@yzhang-gh yzhang-gh added Issue: Performance The ability to respond to user actions quickly. Diagnosis requires expertise and detailed info. and removed Issue: Bug labels Nov 14, 2018
@yzhang-gh yzhang-gh mentioned this issue Jan 15, 2019
Closed
upupming added a commit to upupming/vscode-markdown that referenced this issue Jan 17, 2019
@upupming
Fixed yzhang-gh#323 yzhang-gh#181 yzhang-gh#335 yzhang-gh#354 perform…
62ae361 
…ance issues, support multiple tocs
yzhang-gh pushed a commit that referenced this issue Jan 18, 2019
@upupming
🔀 Fixed #323 #181 #335 #354 performance issues, support multiple tocs (…
4b57734 
…#360)

* Fixed #323 #181 #335 #354 performance issues, support multiple tocs
* Added: tests for multiple tocs, updated old tests
* Using Dice's Coefficient for string similarity
* Updated: testes
* using !==, prevent fake toc, update testes
@yzhang-gh yzhang-gh mentioned this issue Jan 18, 2019
Merged
@yzhang-gh yzhang-gh pinned this issue Jan 18, 2019
@yzhang-gh yzhang-gh unpinned this issue Jan 19, 2019
@yzhang-gh
Copy link
Owner

Should be fixed in v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue: Performance The ability to respond to user actions quickly. Diagnosis requires expertise and detailed info.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lautumn1990 @yzhang-gh @songxianpeng