Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync dd's wallhack for spectator #817

Closed
wants to merge 63 commits into from
Closed

sync dd's wallhack for spectator #817

wants to merge 63 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 27, 2019

No description provided.

yvt added 30 commits January 9, 2017 23:53
Linear rendering is always enabled by means of either FP16 or sRGB framebuffer (thus making EXT_framebuffer_sRGB mandatory)
It’s safe to do this because entire the rendering pipeline now uses the linear color space.
Note that LimboView.cpp no longer exists in v0.2.0 because it was replaced with LimboWindow.as.

# Conflicts:
#	Sources/Client/Client_Update.cpp
#	Sources/Client/LimboView.cpp
yvt and others added 25 commits September 5, 2017 01:03
# Conflicts:
#	OpenSpades.xcodeproj/project.pbxproj
# Conflicts:
#	Sources/Client/Client.cpp
#	Sources/Client/Client_Input.cpp
#	Sources/Client/Client_NetHandler.cpp
#	Sources/Client/FTFont.cpp
#	Sources/Client/LimboView.h
#	Sources/Gui/StartupScreen.cpp
Currently, the following steps are used:
 * <90: green
 * <120: yellow
 * <200: orange
 * >200: red

It currently looks waaay to colorful. I think a colored bar or something might
look best, but for now this works and lets you quickly see how good you can
expect the connection to be
# Conflicts:
#	Resources/Scripts/Gui/ClientUI.as
#	Resources/Scripts/Gui/MainScreen.as
#	Resources/Scripts/Gui/StartupScreen.as
#	Resources/Scripts/Gui/UIControls.as
# Conflicts:
#	Resources/PackageInfo.json
#	XSpades/PackageInfo.json
@ghost ghost closed this Mar 27, 2019
@ghost
Copy link
Author

ghost commented Mar 27, 2019

Sorry, don't know how GitHub works. I didn't mean to interact with master

@NotAFile
Copy link
Contributor

I suppose it's too late now, but I'd like to say that I am not a fan of spectator wallhack code being publicly released. The skill required to comment out the spectator team check in the source and recompile is much lower than the skill required to patch a binary.

@ghost
Copy link
Author

ghost commented Mar 28, 2019

I was just crudely copying and pasting the already public source from DD just the spectator team check section, not the actual wall hack. Within the safety of my fork, I created a pull request thinking that I could sync that branch to my own master. I was really embarrassed to realise this was not the case.
Sorry for the inconvenience @NotAFile

@ghost
Copy link
Author

ghost commented Mar 28, 2019

I am facepalming so hard now. References can be seen on the other issue.
I just didn't want to put the link in and look like I'm purposely trying to be annoying by making it public.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants