Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix l10n_ch_payment_slip report write problem #4

Closed
wants to merge 20 commits into from
Closed

fix l10n_ch_payment_slip report write problem #4

wants to merge 20 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 16, 2018

No description provided.

yvaucher and others added 20 commits June 25, 2018 15:39
@yvaucher @TDu
[MIG] l10n_ch_payment_slip: Migration to 11.0
9258dbe 
Update headers
Port code to python3
Update README
Fix tests with correct report render calls
Adapt code to report module split
@yvaucher @TDu
Rename BVR and BVR/ESR to ISR in english and make it the base term
a504082
@TDu
Fix some docstrings
3325746
@TDu
Fix typo
9778f94
@TDu
Fix test for python3
c077d3c
@TDu
Fix non qweb report not supported
6255c28
@TDu
Remove v11 import
54b7fed 
It has been moved to a own module l10n_ch_import_isr_v11
@TDu
Improve ISR file name
bfa4191
@TDu
Fix english language
1f08e52
@TDu
Add python dependency
7b0da90
@TDu
Simplify js code
fbe9b09
@TDu
Fix batch print ISR
fdf9301
@TDu
Move parameters to setting view
7996134
@grindtildeath
Improve tests and assign bvr_address_format without sudo
0edc55f
@grindtildeath
Allow payment slip to be saved in and read from attachment
92590e3
@grindtildeath
Delete payment slip attachment when setting invoice back to draft
c96bb8b
@grindtildeath
Add test case on attachment management
41e40a5
@grindtildeath
Fix v11
19ec2e6
@yvaucher
Merge pull request #2 from grindtildeath/11.0-mig_tdu_payment_slip
7798a2c 
11.0 mig tdu payment slip
fix l10n_ch_payment_slip report write problem
28fed2e
jcoux
jcoux approved these changes Aug 16, 2018
View reviewed changes
Copy link

@jcoux jcoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only.
LGTM 👍

leemannd
leemannd approved these changes Aug 16, 2018
View reviewed changes
Copy link

@leemannd leemannd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

tschanzt
tschanzt approved these changes Aug 16, 2018
View reviewed changes
Copy link

@tschanzt tschanzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@yvaucher yvaucher force-pushed the 11.0-mig-l10n_ch_payment_slip branch 3 times, most recently from 534ec4a to d963f6e Compare August 21, 2018 08:14
@yvaucher
Copy link
Owner

yvaucher commented Aug 21, 2018 •
edited
Loading

This one is already done in the main PR, thanks for reporting it.

In the mean time I did a couple of fixes to make the whole thing work.

@yvaucher yvaucher closed this Aug 21, 2018
yvaucher pushed a commit that referenced this pull request Feb 23, 2021
@davidwul
# This is a combination of 4 commits.
3f930a3 
# This is the 1st commit message:

85a93e8

# This is the commit message #2:

use qr_iban validation methode

# This is the commit message #3:

fix commit

# This is the commit message #4:

remove debug info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yvaucher @tschanzt @leemannd @jcoux @TDu @grindtildeath