Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example on how to encode using Kotlin #950

Merged
merged 2 commits into from
Oct 15, 2021

Conversation

derlin
Copy link
Contributor

@derlin derlin commented Oct 12, 2021

This kotlin snippet has been tested on the live kroki.io.

Note that I first based the implementation on the Java example, but it didn't work.
I thus adapted it according to https://github.com/DaveJarvis/keenwrite/issues/138#issuecomment-922562707

Note that the java version (converted to Kotlin) didn't work,
and had to be changed according to
https://github.com/DaveJarvis/keenwrite/issues/138#issuecomment-922562707
@ggrossetie
Copy link
Member

Thanks @derlin

I left a few comments but otherwise 👍🏻

@derlin
Copy link
Contributor Author

derlin commented Oct 13, 2021

@Mogztter Thanks for all the relevant comments. Updated the example accordingly :)

@ggrossetie
Copy link
Member

Perfect, thanks! 🙌🏻

@ggrossetie ggrossetie merged commit 4f89eee into yuzutech:main Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants