Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Docker arguments for arm64 builds #1548

Merged
merged 3 commits into from
May 19, 2023
Merged

Add missing Docker arguments for arm64 builds #1548

merged 3 commits into from
May 19, 2023

Conversation

felixvanoost
Copy link
Contributor

Adds missing TARGETARCH and TARGETOS arguments to the BPMN, Diagrams.net, and Excalidraw Dockerfiles to fix the broken arm64 builds of these images. Without these arguments, the binaries are always built for the host architecture (currently amd64) instead of the target.

@felixvanoost felixvanoost mentioned this pull request May 19, 2023
Closed
@ggrossetie ggrossetie merged commit 192e467 into yuzutech:main May 19, 2023
@ggrossetie
Copy link
Member

Thanks!

@felixvanoost felixvanoost deleted the fix-arm64-build-for-companion-images branch May 19, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggrossetie ggrossetie ggrossetie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixvanoost @ggrossetie