-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update excalidraw #1453
Update excalidraw #1453
Conversation
I wasn't aware of that, it seems that |
It's somehow still there but definitely not released on npm anymore. That's why I opted for |
Do you know why the CI job fails? To me (who knows basically nothing about Maven), it seems unrelated to this change... |
Not really, we install this dependency into a local Maven repository using But somehow Maven cannot find it or more precisely tries to download it from Maven central (remote repository). Indeed, it seems unrelated, might be a Maven upgrade 🤔 |
Latest successful build was running Maven 3.8.7. The CI is now using Maven 3.9.0 👀 |
So Maven 3.9.0 is more strict and try to resolve the parent pom (which is not published). Previous version were more forgiving and basically ignored this error. I will upgrade UMlet to 15.0.0 and fix this issue at the same time. |
@sleiner could you please rebase? |
sure 👍🏻 |
This helps for the upcoming transition to the @excalidraw/excalidraw package which is quite a bit larger than @excalidraw/utils.
@excalidraw/utils has not been released anymore since February 2022.
17883ae
to
1124aae
Compare
@excalidraw/utils has not been released anymore since February 2022.
This patch changes kroki to use the still regulaily updated @excalidraw/excalidraw.
This fixes #1452.