Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update excalidraw #1453

Merged
merged 2 commits into from
Mar 11, 2023
Merged

Update excalidraw #1453

merged 2 commits into from
Mar 11, 2023

Conversation

sleiner
Copy link
Contributor

@sleiner sleiner commented Mar 5, 2023

@excalidraw/utils has not been released anymore since February 2022.

This patch changes kroki to use the still regulaily updated @excalidraw/excalidraw.

This fixes #1452.

@ggrossetie
Copy link
Member

I wasn't aware of that, it seems that @excalidraw/utils was removed from the codebase :(

@sleiner
Copy link
Contributor Author

sleiner commented Mar 6, 2023

It's somehow still there but definitely not released on npm anymore. That's why I opted for @excalidraw/excalidraw.

@sleiner
Copy link
Contributor Author

sleiner commented Mar 6, 2023

Do you know why the CI job fails? To me (who knows basically nothing about Maven), it seems unrelated to this change...

@ggrossetie
Copy link
Member

Not really, we install this dependency into a local Maven repository using mvn install:install-file -Dfile=./umlet/lib/umlet-mini-14.3.0.jar -DgroupId=com.umlet -DartifactId=umlet-mini -Dversion=14.3.0 -Dpackaging=jar

But somehow Maven cannot find it or more precisely tries to download it from Maven central (remote repository).

Indeed, it seems unrelated, might be a Maven upgrade 🤔

@ggrossetie
Copy link
Member

Latest successful build was running Maven 3.8.7. The CI is now using Maven 3.9.0 👀

@ggrossetie
Copy link
Member

So Maven 3.9.0 is more strict and try to resolve the parent pom (which is not published). Previous version were more forgiving and basically ignored this error.

I will upgrade UMlet to 15.0.0 and fix this issue at the same time.

@ggrossetie
Copy link
Member

@sleiner could you please rebase?

@sleiner
Copy link
Contributor Author

sleiner commented Mar 9, 2023

sure 👍🏻

This helps for the upcoming transition to the @excalidraw/excalidraw
package which is quite a bit larger than @excalidraw/utils.
@excalidraw/utils has not been released anymore since February 2022.
@ggrossetie ggrossetie merged commit 583a3df into yuzutech:main Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render differences between kroki.io and excalidraw.com
2 participants