Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WireViz support #1439

Merged
merged 3 commits into from
Feb 8, 2023
Merged

WireViz support #1439

merged 3 commits into from
Feb 8, 2023

Conversation

copyrights
Copy link
Contributor

@copyrights copyrights commented Jan 29, 2023 •
edited
Loading

Add support for WireViz .

this pull request is based on @jhogendorn's https://github.com/jhogendorn/kroki-wireviz

closes #282

@ggrossetie
Copy link
Member

Awesome, thanks!

have you decided when ever to you one companion per library or per technology stack?

I'm leaning toward one companion container per library.
Besides, if someone want to create a single companion container per technology stack they will be able to register it using #1423 (so technically both options will be supported)

@copyrights
Copy link
Contributor Author

Ok, should I extract wireviz into a separate container?

@ggrossetie
Copy link
Member

Yes please!

@copyrights
Copy link
Contributor Author

@ggrossetie done. please review.

@copyrights copyrights changed the title WIP: WireViz support WireViz support Jan 30, 2023
@copyrights
Copy link
Contributor Author

test-containers job should pass with b852ec0. This time I've tested it in my fork first https://github.com/copyrights/kroki/actions/runs/4058513825/jobs/6985528299

@jhogendorn
Copy link

Cool to see this getting some traction. Glad my POC was useful :)

@copyrights
Copy link
Contributor Author

Docs CI has a chicken-and-egg issue 😆

@ggrossetie
Copy link
Member

Docs CI has a chicken-and-egg issue

🥚🐔 😆
That's unfortunate!

Thanks for your contribution, it looks good 👍🏻

@ggrossetie ggrossetie merged commit 3901798 into yuzutech:main Feb 8, 2023
@copyrights copyrights mentioned this pull request Mar 7, 2023
Closed
@copyrights copyrights mentioned this pull request Mar 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Wire diagrams
3 participants
@copyrights @ggrossetie @jhogendorn