Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build-deps): use official builder image(rust-musl-builder:1.57.0 to rust:1.64-slim-bullseye) #1363

Merged
merged 3 commits into from
Nov 3, 2022
Merged

chore(build-deps): use official builder image(rust-musl-builder:1.57.0 to rust:1.64-slim-bullseye) #1363

merged 3 commits into from
Nov 3, 2022

Conversation

arukiidou
Copy link
Contributor

@arukiidou arukiidou commented Nov 2, 2022 •
edited
Loading

  • using official builder image

  • change svgbob_cli builder image(rust-musl-builder:1.57.0 to rust:1.64-slim-bullseye)

    • fixed: builder binary path
    • fixed: specify target platform(x86_64-unknown-linux-musl)

sample Dockerfile

FROM rust:1.64-slim-bullseye AS builder
RUN rustup target add x86_64-unknown-linux-musl
RUN cargo install svgbob_cli --version 0.6.6 --target x86_64-unknown-linux-musl

FROM alpine:3.16
COPY --from=builder /usr/local/cargo/bin/svgbob_cli /usr/bin/svgbob_cli

@arukiidou
change svgbob_cli builder image
dfd3c30 
more simple rust builder
@arukiidou
Update Dockerfile
a123ab5 
fix builder binary directory
@arukiidou arukiidou changed the title change svgbob_cli builder image(rust-musl-builder:1.57.0 to rust:1.64-bullseye) draft:change svgbob_cli builder image(rust-musl-builder:1.57.0 to rust:1.64-bullseye) Nov 2, 2022
@arukiidou arukiidou marked this pull request as draft November 2, 2022 16:16
@arukiidou
add target platform
ac6dd3c 
```
# syntax = docker/dockerfile:1.4
FROM rust:1.64-slim-bullseye AS builder
RUN rustup target add x86_64-unknown-linux-musl
RUN cargo install svgbob_cli --version 0.6.6 --target x86_64-unknown-linux-musl
```
@arukiidou arukiidou marked this pull request as ready for review November 3, 2022 06:42
@arukiidou arukiidou changed the title draft:change svgbob_cli builder image(rust-musl-builder:1.57.0 to rust:1.64-bullseye) svgbob_cli builder image(rust-musl-builder:1.57.0 to rust:1.64-bullseye) Nov 3, 2022
@arukiidou arukiidou changed the title svgbob_cli builder image(rust-musl-builder:1.57.0 to rust:1.64-bullseye) chore(build-deps): svgbob_cli builder image(rust-musl-builder:1.57.0 to rust:1.64-bullseye) Nov 3, 2022
@arukiidou arukiidou changed the title chore(build-deps): svgbob_cli builder image(rust-musl-builder:1.57.0 to rust:1.64-bullseye) chore(build-deps): maintained builder image(rust-musl-builder:1.57.0 to rust:1.64-bullseye) Nov 3, 2022
@arukiidou arukiidou changed the title chore(build-deps): maintained builder image(rust-musl-builder:1.57.0 to rust:1.64-bullseye) chore(build-deps): use official builder image(rust-musl-builder:1.57.0 to rust:1.64-bullseye) Nov 3, 2022
@arukiidou arukiidou changed the title chore(build-deps): use official builder image(rust-musl-builder:1.57.0 to rust:1.64-bullseye) chore(build-deps): use official builder image(rust-musl-builder:1.57.0 to rust:1.64-slim-bullseye) Nov 3, 2022
@ggrossetie
Copy link
Member

Thank you 👍🏻

@ggrossetie ggrossetie merged commit 8e2bfb8 into yuzutech:main Nov 3, 2022
@arukiidou arukiidou deleted the patch-1 branch November 3, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arukiidou @ggrossetie