Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #970 use cargo.toml to install svgbob #1318

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

ssaraswati
Copy link
Contributor

Addresses #970 by converting the build-static-svgbob to use a Cargo.toml file instead of specifying version directly

I wasn't able to get a full build of kroki to run on my machine but this did seem to work correctly with COPY --from=kroki-builder-static-svgbobs:latest /home/rust/.cargo/bin/svgbob /usr/bin/svgbob from server/ops/docker/jdk11-alpine/Dockerfile

@ggrossetie
Copy link
Member

Thanks for taking care of this issue 👍🏻
I left a few comments but it looks very good.

I wasn't able to get a full build of kroki to run on my machine

Let's see what the CI says.

@ssaraswati
Copy link
Contributor Author

Thanks for taking care of this issue 👍🏻 I left a few comments but it looks very good.

I wasn't able to get a full build of kroki to run on my machine

Let's see what the CI says.

HI @Mogztter from the failed CI run it doesn't look like my initial approach is likely to work. I have taken a second go doing this via SED to extract the svgbob_cli version from the Cargo.toml file instead.

This approach seems to work fine with Renovate and doesn't require the full Cargo.toml file values to be specified. I have run a copy of renovate against it on my fork and PR was created with new svgbob versions https://github.com/ssaraswati/kroki/pull/3/files

@ggrossetie ggrossetie changed the title Use cargo.toml to install svgbob resolves #970 use cargo.toml to install svgbob Aug 31, 2022
@ggrossetie ggrossetie merged commit 1246ee4 into yuzutech:main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants