resolves #1064 Fixes date-related HTTP headers #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcelWaldvogel
force-pushed
the
date-headers
branch
from
8a3d1a3
to
a2f6e06
Compare
|
Works as it should and fixes #1064 . Generating a test for it seems overly complicated, so I'll refrain from it for now. I hope you agree. |
It should be relatively straightforward if But first let's agree on what we should do (in the issue) |
* Upgrade maven-resources-plugin to 3.1.0, as 2.6 does not
correctly replace `${maven.build.timestamp}`
* Move reading the properties to `Main`, as it is now kind of global
|
Sorry, I just saw that you pushed new commits, I will review 👍🏻 |
|
Made a few adjustments but otherwise it's great, thanks 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes date headers to the HTTP format.
(Not tested yet, please wait with merging)