Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #1055 upgrade C4 PlantUML definition files to 2.4.0 #1056

Merged
merged 1 commit into from
Jan 9, 2022
Merged

resolves #1055 upgrade C4 PlantUML definition files to 2.4.0 #1056

merged 1 commit into from
Jan 9, 2022

Conversation

mikaello
Copy link
Contributor

@mikaello mikaello commented Jan 7, 2022

Copy link
Member

@ggrossetie ggrossetie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are loading C4 files from the classpath we need to remove the logic that includes dependent files using the !include directive.

Apart from that 👍🏻

Copied from: https://github.com/plantuml-stdlib/C4-PlantUML/tree/v2.4.0
, and removed the logic that includes dependent files using the `!include`
directive
@ggrossetie
Copy link
Member

Thank you for your contribution 🙌🏻

@ggrossetie ggrossetie merged commit 497b83c into yuzutech:main Jan 9, 2022
@mikaello mikaello deleted the upgrade-c4-plantuml-definition-files-to-2-4-0 branch January 9, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade C4 PlantUML to version 2.4.0
2 participants