Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump blockdiag and *diag dependencies to 3.0.0 #1017

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

nejch
Copy link
Contributor

@nejch nejch commented Dec 7, 2021

Related to blockdiag/blockdiag#147.

Replaces #1016, #1015, #1014, #1013 because they require funcparserlib 1.0.0a0 to work (as discussed in blockdiag PRs).

@nejch nejch marked this pull request as draft December 7, 2021 11:02
@nejch nejch marked this pull request as ready for review December 7, 2021 11:13
@nejch
Copy link
Contributor Author

nejch commented Dec 7, 2021

@Mogztter I also had to change a few fixtures, might be related to some additional margins in 3.0.0 though I haven't explored in detail (see https://github.com/blockdiag/seqdiag/blob/master/CHANGES.rst#300-2021-12-06).

@ggrossetie
Copy link
Member

Replaces #1016, #1015, #1014, #1013 because they require funcparserlib 1.0.0a0 to work (as discussed in blockdiag PRs).

@nejch Woot woot, thanks! 🎉

I also had to change a few fixtures, might be related to some additional margins in 3.0.0 though I haven't explored in detail (see blockdiag/seqdiag@master/CHANGES.rst#300-2021-12-06).

I think it's fine, changes seem relatively small and harmless.

@ggrossetie ggrossetie merged commit c8791c9 into yuzutech:main Dec 7, 2021
@nejch nejch deleted the chore/bump-blockdiag-deps branch December 7, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants