Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C4 PlantUML missing support for SHOW_DYNAMIC_LEGEND #675

Closed
koriit-kontakt opened this issue Apr 2, 2021 · 4 comments
Closed

C4 PlantUML missing support for SHOW_DYNAMIC_LEGEND #675

koriit-kontakt opened this issue Apr 2, 2021 · 4 comments
Labels
👶 good first issue Good for newcomers 🍩 enhancement New feature or request 👋 help wanted Help wanted!

Comments

@koriit-kontakt
Copy link

Hi!
I noticed that C4 PlantUML is missing support for SHOW_DYNAMIC_LEGEND macro function.

If I understand correctly kroki is replacing stdlib C4 includes with:
https://github.com/yuzutech/kroki/blob/master/server/src/main/resources/c4.puml

And SHOW_DYNAMIC_LEGEND was implemented after the last update to the kroki's file:
https://github.com/plantuml-stdlib/C4-PlantUML/blame/master/C4.puml#L298

Thanks!

@ggrossetie ggrossetie added 👶 good first issue Good for newcomers 👋 help wanted Help wanted! 🍩 enhancement New feature or request labels Apr 2, 2021
@ggrossetie
Copy link
Member

ggrossetie commented Apr 2, 2021

Hi @koriit-kontakt

Yes that's correct if you are using the public instance kroki.io. If you are using your own instance then you can include any local or remote files.
Please note that it's also depend on how you are including the C4 definitions files. If you are using the following syntax:

!include <C4/C4_Container>

Then, PlantUML will use: https://github.com/plantuml/plantuml/tree/master/stdlib

This feature is not yet available in a release/tag. The latest release/tag is 2.0.1 and does not contain this feature: https://github.com/plantuml-stdlib/C4-PlantUML/blob/v2.0.1/C4.puml

Once this feature is released, feel free to send a pull request to update the files in server/src/main/resources.

@koriit-kontakt
Copy link
Author

Oh, so that's how it is. Thanks for the clarification.

@koriit-kontakt
Copy link
Author

sladkoff added a commit to sladkoff/kroki that referenced this issue Apr 7, 2021
ggrossetie added a commit that referenced this issue Apr 10, 2021
#675: Update C4 definition files
@ggrossetie
Copy link
Member

resolved in 86d59a0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👶 good first issue Good for newcomers 🍩 enhancement New feature or request 👋 help wanted Help wanted!
Projects
None yet
Development

No branches or pull requests

2 participants