Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
123522: dbconsole: overload page improvements r=sumeerbhola a=aadityasondhi This PR contains a series of improvements to the overload page of the DB console as part of cockroachdb#121574. It is separated into multiple commits for ease of review. ____ dbconsole: remove non useful charts on the overload page In investigations, we have found that the following charts are not useful and frequently cause confusion: - Admission work rate - Admission Delay rate - Requests Waiting For Flow Tokens Informs cockroachdb#121572 Release note (ui change): This patch removes "Admission Delay Rate", "Admission Work Rate", and "Requests Waiting For Flow Tokens". These charts often cause confusion and are not useful for general overload investigations. ___ dbconsole: reorder overload page metrics for better readability This patch reorders the existing metrics in a more usable order: 1. Metrics to help determine which resource is constrained (IO, CPU) 2. Metrics to narrow down which AC queues are seeing requests waiting 3. More advanced metrics about the system health (goroutine scheduler, L0 sublevels, etc.) Informs cockroachdb#121572. Release note (ui change): Reordering of metrics on the overload page to help categorizing them better. They are roughly in the following order: 1. Metrics to help determine which resource is constrained (IO, CPU) 2. Metrics to narrow down which AC queues are seeing requests waiting 3. More advanced metrics about the system health (goroutine scheduler, L0 sublevels, etc.) ___ dbconsole: include better names and descriptions for overload page This patch improves the metric descriptions for the metrics on the overload page. Fixes cockroachdb#120853. Release note (ui change): The overload page now includes descriptions for all metrics. ___ dbconsole: additional higher granularity metrics for overload This patch adds additional metrics to the overload page that allow for more granular look at the system: - cr.store.storage.l0-sublevels - cr.node.go.scheduler_latency-p99.9 Informs cockroachdb#121572. Release note (ui change): Two additional metrics on the overload page for better visibility into overloaded resources: - cr.store.storage.l0-sublevels - cr.node.go.scheduler_latency-p99.9 ___ dbconsole: split Admission Queue graphs to avoid overcrowding Informs cockroachdb#121572. Release note (ui change): There are now 4 graphs for Admission Queue Delay: 1. Foreground (regular) CPU work 2. Store (IO) work 3. Background (elastic) CPU work 4. Replication Admission Control, store overload on replicas ___ dbconsole: add elastic store metric to the overload page This patch uses the new sperated `elastic-stores` metrics for queing delay from cockroachdb#123890. Informs cockroachdb#121572. Release note (ui change): The `Admission Queueing Delay – Store` chart now separates elastic (background) work from the regular foreground work. ___ dbconsole: add elastic io token exhausted duration to overload page This patch adds the metric `elastic_io_tokens_exhausted_duration.kv` introduced in cockroachdb#124078. Informs cockroachdb#121572. Release note (ui change): The `Admission IO Tokens Exhausted` chart now separates elastic and regular io work. 124493: packer: only try emulating via Docker on x86 r=rail a=rickystewart Epic: none Release note: None Co-authored-by: Aaditya Sondhi <[email protected]> Co-authored-by: Ricky Stewart <[email protected]>
- Loading branch information