resolve code review comments

Signed-off-by: yuye-aws <[email protected]>
yuye-aws · Mar 8, 2024 · e89c063 · e89c063
1 parent bb263cc
commit e89c063
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/main/java/org/opensearch/neuralsearch/processor/DocumentChunkingProcessor.java b/src/main/java/org/opensearch/neuralsearch/processor/DocumentChunkingProcessor.java
@@ -130,8 +130,8 @@ private void validateAndParseAlgorithmMap(Map<String, Object> algorithmMap) {
             this.chunkerType = algorithmKey;
             this.chunkerParameters = (Map<String, Object>) algorithmValue;
             chunker.validateParameters(chunkerParameters);
-            if (((Map<String, Object>) algorithmValue).containsKey(MAX_CHUNK_LIMIT_FIELD)) {
-                String maxChunkLimitString = ((Map<String, Object>) algorithmValue).get(MAX_CHUNK_LIMIT_FIELD).toString();
+            if (chunkerParameters.containsKey(MAX_CHUNK_LIMIT_FIELD)) {
+                String maxChunkLimitString = chunkerParameters.get(MAX_CHUNK_LIMIT_FIELD).toString();
                 if (!(NumberUtils.isParsable(maxChunkLimitString))) {
                     throw new IllegalArgumentException(
                         "Parameter [" + MAX_CHUNK_LIMIT_FIELD + "] cannot be cast to [" + Number.class.getName() + "]"
@@ -147,7 +147,7 @@ private void validateAndParseAlgorithmMap(Map<String, Object> algorithmMap) {
     }
 
     @SuppressWarnings("unchecked")
-    private boolean isListString(Object value) {
+    private boolean isListOfString(Object value) {
         // an empty list is also List<String>
         if (!(value instanceof List)) {
             return false;
@@ -191,7 +191,7 @@ private List<String> chunkLeafType(Object value, ChunkCountWrapper chunkCountWra
         List<String> chunkedResult = null;
         if (value instanceof String) {
             chunkedResult = chunkString(value.toString(), chunkCountWrapper);
-        } else if (isListString(value)) {
+        } else if (isListOfString(value)) {
             chunkedResult = chunkList((List<String>) value, chunkCountWrapper);
         }
         return chunkedResult;