tune method name in delimiter algorithm unit test

Signed-off-by: yuye-aws <[email protected]>
yuye-aws · Mar 15, 2024 · e4bdabc · e4bdabc
1 parent 3f41f37
commit e4bdabc
Showing 1 changed file with 8 additions and 15 deletions.
diff --git a/src/test/java/org/opensearch/neuralsearch/processor/chunker/DelimiterChunkerTests.java b/src/test/java/org/opensearch/neuralsearch/processor/chunker/DelimiterChunkerTests.java
@@ -15,7 +15,7 @@
 
 public class DelimiterChunkerTests extends OpenSearchTestCase {
 
-    public void testChunkerWithDelimiterFieldNotString() {
+    public void testCreate_withDelimiterFieldInvalidType_thenFail() {
         Exception exception = assertThrows(
             IllegalArgumentException.class,
             () -> new DelimiterChunker(Map.of(DELIMITER_FIELD, List.of("")))
@@ -26,55 +26,48 @@ public void testChunkerWithDelimiterFieldNotString() {
         );
     }
 
-    public void testChunkerWithDelimiterFieldNoString() {
+    public void testCreate_withDelimiterFieldEmptyString_thenFail() {
         Exception exception = assertThrows(IllegalArgumentException.class, () -> new DelimiterChunker(Map.of(DELIMITER_FIELD, "")));
         Assert.assertEquals(String.format(Locale.ROOT, "Parameter [%s] should not be empty.", DELIMITER_FIELD), exception.getMessage());
     }
 
-    public void testChunker() {
+    public void testChunk_withNewlineDelimiter_thenSucceed() {
         DelimiterChunker chunker = new DelimiterChunker(Map.of(DELIMITER_FIELD, "\n"));
         String content = "a\nb\nc\nd";
         List<String> chunkResult = chunker.chunk(content, Map.of());
         assertEquals(List.of("a\n", "b\n", "c\n", "d"), chunkResult);
     }
 
-    public void testChunkerWithDefaultDelimiter() {
+    public void testChunk_withDefaultDelimiter_thenSucceed() {
         // default delimiter is \n\n
         DelimiterChunker chunker = new DelimiterChunker(Map.of());
         String content = "a.b\n\nc.d";
         List<String> chunkResult = chunker.chunk(content, Map.of());
         assertEquals(List.of("a.b\n\n", "c.d"), chunkResult);
     }
 
-    public void testChunkerWithDelimiterEnd() {
-        DelimiterChunker chunker = new DelimiterChunker(Map.of(DELIMITER_FIELD, "\n"));
-        String content = "a\nb\nc\nd\n";
-        List<String> chunkResult = chunker.chunk(content, Map.of());
-        assertEquals(List.of("a\n", "b\n", "c\n", "d\n"), chunkResult);
-    }
-
-    public void testChunkerWithOnlyDelimiter() {
+    public void testChunk_withOnlyDelimiterContent_thenSucceed() {
         DelimiterChunker chunker = new DelimiterChunker(Map.of(DELIMITER_FIELD, "\n"));
         String content = "\n";
         List<String> chunkResult = chunker.chunk(content, Map.of());
         assertEquals(List.of("\n"), chunkResult);
     }
 
-    public void testChunkerWithAllDelimiters() {
+    public void testChunk_WithAllDelimiterContent_thenSucceed() {
         DelimiterChunker chunker = new DelimiterChunker(Map.of(DELIMITER_FIELD, "\n"));
         String content = "\n\n\n";
         List<String> chunkResult = chunker.chunk(content, Map.of());
         assertEquals(List.of("\n", "\n", "\n"), chunkResult);
     }
 
-    public void testChunkerWithDifferentDelimiters() {
+    public void testChunk_WithPeriodDelimiters_thenSucceed() {
         DelimiterChunker chunker = new DelimiterChunker(Map.of(DELIMITER_FIELD, "."));
         String content = "a.b.cc.d.";
         List<String> chunkResult = chunker.chunk(content, Map.of());
         assertEquals(List.of("a.", "b.", "cc.", "d."), chunkResult);
     }
 
-    public void testChunkerWithStringDelimiter() {
+    public void testChunk_withDoubleNewlineDelimiter_thenSucceed() {
         DelimiterChunker chunker = new DelimiterChunker(Map.of(DELIMITER_FIELD, "\n\n"));
         String content = "\n\na\n\n\n";
         List<String> chunkResult = chunker.chunk(content, Map.of());