adjust exception message

Signed-off-by: yuye-aws <[email protected]>
yuye-aws · Mar 14, 2024 · 3cf671d · 3cf671d
1 parent 06ca1c7
commit 3cf671d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/main/java/org/opensearch/neuralsearch/processor/chunker/ChunkerParameterValidator.java b/src/main/java/org/opensearch/neuralsearch/processor/chunker/ChunkerParameterValidator.java
@@ -26,7 +26,7 @@ public static void validateStringParameter(final Map<String, Object> parameters,
         Object fieldValue = parameters.get(fieldName);
         if (!(fieldValue instanceof String)) {
             throw new IllegalArgumentException(
-                String.format(Locale.ROOT, "Parameter [%s] cannot be cast to [%s]", fieldName, String.class.getName())
+                String.format(Locale.ROOT, "Parameter [%s] must be of %s type", fieldName, String.class.getName())
             );
         }
         if (!allowEmpty && StringUtils.isEmpty(fieldValue.toString())) {
@@ -49,7 +49,7 @@ public static void validatePositiveIntegerParameter(
         String fieldValueString = parameters.get(fieldName).toString();
         if (!(NumberUtils.isParsable(fieldValueString))) {
             throw new IllegalArgumentException(
-                String.format(Locale.ROOT, "Parameter [%s] cannot be cast to [%s]", fieldName, Number.class.getName())
+                String.format(Locale.ROOT, "Parameter [%s] must be of %s type", fieldName, Number.class.getName())
             );
         }
         int fieldValueInt = NumberUtils.createInteger(fieldValueString);
@@ -75,7 +75,7 @@ public static void validateDoubleParameterWithinRange(
         String fieldValueString = parameters.get(fieldName).toString();
         if (!(NumberUtils.isParsable(fieldValueString))) {
             throw new IllegalArgumentException(
-                String.format(Locale.ROOT, "Parameter [%s] cannot be cast to [%s]", fieldName, Number.class.getName())
+                String.format(Locale.ROOT, "Parameter [%s] must be of %s type", fieldName, Number.class.getName())
             );
         }
         double fieldValueDouble = NumberUtils.createDouble(fieldValueString);

diff --git a/src/test/java/org/opensearch/neuralsearch/processor/chunker/DelimiterChunkerTests.java b/src/test/java/org/opensearch/neuralsearch/processor/chunker/DelimiterChunkerTests.java
@@ -21,7 +21,7 @@ public void testChunkerWithDelimiterFieldNotString() {
             () -> new DelimiterChunker(Map.of(DELIMITER_FIELD, List.of("")))
         );
         Assert.assertEquals(
-            String.format(Locale.ROOT, "Parameter [%s] cannot be cast to [%s]", DELIMITER_FIELD, String.class.getName()),
+            String.format(Locale.ROOT, "Parameter [%s] must be of %s type", DELIMITER_FIELD, String.class.getName()),
             exception.getMessage()
         );
     }

diff --git a/...test/java/org/opensearch/neuralsearch/processor/chunker/FixedTokenLengthChunkerTests.java b/...test/java/org/opensearch/neuralsearch/processor/chunker/FixedTokenLengthChunkerTests.java
@@ -74,7 +74,7 @@ public void testValidateAndParseParameters_whenIllegalTokenLimitType_thenFail()
             () -> fixedTokenLengthChunker.validateParameters(parameters)
         );
         assertEquals(
-            String.format(Locale.ROOT, "Parameter [%s] cannot be cast to [%s]", TOKEN_LIMIT_FIELD, Number.class.getName()),
+            String.format(Locale.ROOT, "Parameter [%s] must be of %s type", TOKEN_LIMIT_FIELD, Number.class.getName()),
             illegalArgumentException.getMessage()
         );
     }
@@ -100,7 +100,7 @@ public void testValidateAndParseParameters_whenIllegalOverlapRateType_thenFail()
             () -> fixedTokenLengthChunker.validateParameters(parameters)
         );
         assertEquals(
-            String.format(Locale.ROOT, "Parameter [%s] cannot be cast to [%s]", OVERLAP_RATE_FIELD, Number.class.getName()),
+            String.format(Locale.ROOT, "Parameter [%s] must be of %s type", OVERLAP_RATE_FIELD, Number.class.getName()),
             illegalArgumentException.getMessage()
         );
     }
@@ -126,7 +126,7 @@ public void testValidateAndParseParameters_whenIllegalTokenizerType_thenFail() {
             () -> fixedTokenLengthChunker.validateParameters(parameters)
         );
         assertEquals(
-            String.format(Locale.ROOT, "Parameter [%s] cannot be cast to [%s]", TOKENIZER_FIELD, String.class.getName()),
+            String.format(Locale.ROOT, "Parameter [%s] must be of %s type", TOKENIZER_FIELD, String.class.getName()),
             illegalArgumentException.getMessage()
         );
     }