You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What version of goldmark are you using? :
Latest from master i.e. v1.1.21 or faaafa5
What version of Go are you using? : go version go1.13.5 linux/amd64
What operating system and processor architecture are you using? : Fedora 31 on amd64
What did you do? :
package main
import (
"fmt""github.com/yuin/goldmark""bytes"
)
funcmain() {
source2:=`[This link won't be renderedcorrectly](https://geeksocket.in/some-long-link-here "This is theplace where everything breaks")`varbuf bytes.Bufferiferr:=goldmark.Convert([]byte(source2), &buf); err!=nil {
panic(err)
}
fmt.Println(buf.String())
}
What did you expect to see? :
The link should get rendered correctly with title attribute set.
What did you see instead? :
It get's rendered as
<p>[This link won't be rendered
correctly](https://geeksocket.in/some-long-link-here "This is the
place where everything breaks")</p>
Did you confirm your output is different from CommonMark online demo or other official renderer correspond with an extension?:
Yes.
I tried going trough the source code and debug this issue, but I wasn't able to completely understand what all is happening in parseBlock function here https://github.com/yuin/goldmark/blob/master/parser/parser.go#L1106
For the link label it advances the next line segment correctly but for the title text it doesn't.
Would like to send a fix if anyone can help me to understand why it's failing.
The text was updated successfully, but these errors were encountered:
v1.1.22 has a fix for issue where links with newline in the title
don't get parsed correctly. Reference:
yuin/goldmark#94
Signed-off-by: Bhavin Gandhi <[email protected]>
v1.1.22 has a fix for issue where links with newline in the title
don't get parsed correctly. Reference:
yuin/goldmark#94
Signed-off-by: Bhavin Gandhi <[email protected]>
Latest from master i.e.
v1.1.21
or faaafa5go version go1.13.5 linux/amd64
Fedora 31 on amd64
The link should get rendered correctly with title attribute set.
It get's rendered as
Yes.
I tried going trough the source code and debug this issue, but I wasn't able to completely understand what all is happening in parseBlock function here https://github.com/yuin/goldmark/blob/master/parser/parser.go#L1106
For the link label it advances the next line segment correctly but for the title text it doesn't.
Would like to send a fix if anyone can help me to understand why it's failing.
The text was updated successfully, but these errors were encountered: