Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chroma #14

Merged
merged 1 commit into from
Mar 7, 2020
Merged

Update chroma #14

merged 1 commit into from
Mar 7, 2020

Conversation

satotake
Copy link
Contributor

@satotake satotake commented Mar 7, 2020

Upstream chroma had trouble with windows' style line ending (=\r\n), resulting in broken htmls
The issue was fixed with alecthomas/chroma#336 .
This update will fix downstream issue (gohugoio/hugo#6596)

Example

With an attached python-snippet.txt

Actual result (note </span>yle... just after </h1>)

<h1>Title</h1>
</span>yle="background-color:#fff"><span style="color:#998;font-style:italic"># launch program
<span style="color:#000;font-weight:bold">def</span> <span style="color:#900;font-weight:bold">main</span>():
    <span style="color:#000;font-weight:bold">print</span>(<span style="color:#099">1</span>)
</pre>

Expected result

<h1>Title</h1>
<pre style="background-color:#fff"><span style="color:#998;font-style:italic"># launch program</span>
<span style="color:#000;font-weight:bold">def</span> <span style="color:#900;font-weight:bold">main</span>():
    <span style="color:#000;font-weight:bold">print</span>(<span style="color:#099">1</span>)
</pre>

@yuin yuin merged commit 60d527f into yuin:master Mar 7, 2020
@satotake
Copy link
Contributor Author

satotake commented Mar 7, 2020

Thank you 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants