Bump yui version to ^3.14.1 #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
| @@ -75,7 +75,7 @@ | |||
| "marked": "^0.3.2", | |||
| "minimatch": "^1.0.0", | |||
| "rimraf": "2.x", | |||
| "yui": "3.14.1" | |||
| "yui": "3.18.x" | |||
There was a problem hiding this comment.
since yuidocs pretty much works with any yui version, why don't we just use ^3.14.1?
There was a problem hiding this comment.
the reason why, it is because in many cases, people will aready have yui dep in their app, and that reduces the amount of yui installments in your app. Obviosly, this is assuming you are not using any of the new features of yui in yuidoc
There was a problem hiding this comment.
I'm not sure why we don't use ^ or ~. YUIDoc should works with any YUI versions, but I just wanted to depend on YUI 3.18.0 or later to follow request updates (see yui/yui3#1934) expressly. Even ^3.18.1 and ^3.14.1 will be fine to me, too.
|
Okay, I just change to depends on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.