Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for doc ticket Enforce TLS versions #7277 #7306

Merged
merged 2 commits into from
Feb 23, 2021

Conversation

lizayugabyte
Copy link
Contributor

PR for doc ticket Enforce TLS versions #7277

@lizayugabyte lizayugabyte changed the title Updated YB Platform files PR for doc ticket Enforce TLS versions #7277 Feb 19, 2021
@lizayugabyte lizayugabyte linked an issue Feb 19, 2021 that may be closed by this pull request
@lizayugabyte lizayugabyte self-assigned this Feb 19, 2021
Copy link
Contributor

@chirag-yb chirag-yb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't mention v1.3 anywhere yet and let's keep all references at 1.2. And this needs to also go in the stable release documentation

5. Optionally, set the TLS version for Nginx frontend by using `ssl_protocols` operational directive in the Helm installation, as follows:

```sh
helm install yw-test yugabytedb/yugaware --version 2.3.3 -n yb-platform --wait --set tls.sslProtocols="TLSv1.2 TLSv1.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove TLS 1.3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for nginx, TLS1.3 is supported.
Please add two more parameters to nginx part.
ssl_protocols TLSv1.2 TLSv1.3; # Tell client which ciphers are available
ssl_prefer_server_ciphers on;
ssl_ciphers ECDH+AESGCM:ECDH+AES256:ECDH+AES128:DH+3DES:!ADH:!AECDH:!MD5; # this is customized and vary from customers security requirement. Some customers don't like 3DES.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chirag-yb @ssung-yugabyte Chirag, please confirm that you are okay with the changes that Stanley suggested

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssung-yugabyte since we don't support TLS v1.3 in the entire product I recommend not mentioning it anywhere. I would imaging enterprises keeping the same version across the entire platform and not assigning different versions to YB Nginx and YB DBs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iSignal do we support setting ciphers from our helm charts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chirag-yb Would you like me to merge now? Or wait for answer?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizayugabyte Please merge it for now.

@lizayugabyte lizayugabyte merged commit 5003149 into yugabyte:master Feb 23, 2021
polarweasel pushed a commit to lizayugabyte/yugabyte-db that referenced this pull request Mar 9, 2021
* Updated YB Platform files

* Deleted refs to TLS 1.3

```
ssl_protocols = tlsv12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, this should have been ssl_protocols = tls12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Enforce TLS versions
4 participants