-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#7024] Platform: Fixed edit number of nodes in AZ section #7029
Conversation
Fix: currentPlacementStatus prop was null initially when we land to edit universe page, so in mounting lifecycle i fetched this info if it is undefined or null. |
This pull request introduces 1 alert when merging 9b4f091 into 84ebc32 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 6f363e9 into 84ebc32 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before ad3a72a commit the currentPlacementStatus
prop was filled here
this.props.setPlacementStatus(placementStatusObject); |
Now this never happens due to extra conditions added at ClusterFields component:
{placementStatusOnprem || regionAndProviderDefined && azSelectorTable}
This seems to be the real root cause, so let's investigate in that direction pls.
After adding the above condition |
…ugabyte#7029) Description: The user was not able to edit the numbers of nodes from the AZ section while editing the universe. The issue was due to an undefined variable on the initial rendering. Added the API call to set the context for the number of nodes in the AZ section. Test scenario: Able to modify the number of nodes from the AZ section while editing the universe.
…ction (yugabyte#7029)" (yugabyte#7329) Description: This reverts commit bccf91f. This commit was causing page crash while region selection during create universe.
Description: The user was not able to edit the numbers of nodes from the AZ section while editing the universe.