Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#7024] Platform: Fixed edit number of nodes in AZ section #7029

Merged
merged 3 commits into from
Feb 19, 2021

Conversation

gaurav061
Copy link
Contributor

@gaurav061 gaurav061 commented Jan 29, 2021

Description: The user was not able to edit the numbers of nodes from the AZ section while editing the universe.

@gaurav061
Copy link
Contributor Author

Fix: currentPlacementStatus prop was null initially when we land to edit universe page, so in mounting lifecycle i fetched this info if it is undefined or null.
Please add your comments

@lgtm-com
Copy link

lgtm-com bot commented Jan 29, 2021

This pull request introduces 1 alert when merging 9b4f091 into 84ebc32 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jan 29, 2021

This pull request introduces 1 alert when merging 6f363e9 into 84ebc32 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Copy link
Collaborator

@sshev sshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before ad3a72a commit the currentPlacementStatus prop was filled here

this.props.setPlacementStatus(placementStatusObject);

Now this never happens due to extra conditions added at ClusterFields component:
{placementStatusOnprem || regionAndProviderDefined && azSelectorTable}

This seems to be the real root cause, so let's investigate in that direction pls.

@gaurav061
Copy link
Contributor Author

gaurav061 commented Feb 5, 2021

After adding the above condition {placementStatusOnprem || regionAndProviderDefined && azSelectorTable}AzSelector component is being rendered with this _.isEqual(universeConfigTemplate, this.props.universe.universeConfigTemplate) as true and thus it is blocking this this.props.setPlacementStatus(placementStatusObject); So, we need this call to be made in UNSAFE_componentWillMount lifecycle for 1st time rendering for subsequent rending the call will be made from UNSAFE_componentWillReceiveProps lifecycle.
Please add to it.

@gaurav061 gaurav061 requested a review from sshev February 15, 2021 11:15
@gaurav061 gaurav061 merged commit bccf91f into yugabyte:master Feb 19, 2021
gaurav061 added a commit that referenced this pull request Feb 21, 2021
gaurav061 added a commit that referenced this pull request Feb 22, 2021
…7029)" (#7329)

Description: This reverts commit bccf91f. This commit was causing page crash while region selection during create universe.
polarweasel pushed a commit to lizayugabyte/yugabyte-db that referenced this pull request Mar 9, 2021
…ugabyte#7029)

Description: The user was not able to edit the numbers of nodes from the AZ section while editing the universe. The issue was due to an undefined variable on the initial rendering. Added the API call to set the context for the number of nodes in the AZ section.

Test scenario: Able to modify the number of nodes from the AZ section while editing the universe.
polarweasel pushed a commit to lizayugabyte/yugabyte-db that referenced this pull request Mar 9, 2021
…ction (yugabyte#7029)" (yugabyte#7329)

Description: This reverts commit bccf91f. This commit was causing page crash while region selection during create universe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants