Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Use ysql_hba_conf_csv everywhere #6920

Merged
merged 5 commits into from
Jan 21, 2021
Merged

[docs] Use ysql_hba_conf_csv everywhere #6920

merged 5 commits into from
Jan 21, 2021

Conversation

ddorian
Copy link
Contributor

@ddorian ddorian commented Jan 19, 2021

Deprecate ysql_hba_conf and use ysql_hba_conf_csv everywhere.

fixes #6710

@ddorian ddorian added the area/documentation Documentation needed label Jan 19, 2021
@ddorian ddorian changed the title [docs] User ysql_hba_conf_csv everywhere [docs] Use ysql_hba_conf_csv everywhere Jan 20, 2021
lizayugabyte
lizayugabyte reviewed Jan 20, 2021
View reviewed changes
Copy link
Contributor

@lizayugabyte lizayugabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Could use colons before lists.

d-uspenskiy
d-uspenskiy reviewed Jan 20, 2021
View reviewed changes
Copy link
Contributor

@d-uspenskiy d-uspenskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ddorian
Copy link
Contributor Author

ddorian commented Jan 21, 2021

@lizayugabyte

Looks fine. Could use colons before lists.

Can you point where ? I don't understand.

@lizayugabyte
Copy link
Contributor

A colon should be used before the list starts. E.g., after "connections"

Specifies the comma-separated list of the network interface addresses to bind to for RPC connections.
- Typically, the value is set to the private IP address of the host on which the server is running. When using the default, or explicitly setting the value to 0.0.0.0:9100, the server will listen on all available network interfaces.
- The values must match on all yb-master and yb-tserver configurations.

@ddorian ddorian merged commit 7c2d826 into yugabyte:master Jan 21, 2021
@ddorian ddorian deleted the doc-ysql_hba_conf_csv branch January 21, 2021 17:08
polarweasel pushed a commit to lizayugabyte/yugabyte-db that referenced this pull request Mar 9, 2021
@ddorian
[docs] Use ysql_hba_conf_csv everywhere (yugabyte#6920)
b256cf5 
* deprecate ysql_hba_conf
* ysql_hba_conf -> ysql_hba_conf_csv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizayugabyte lizayugabyte lizayugabyte left review comments

@d-uspenskiy d-uspenskiy d-uspenskiy left review comments

Assignees
No one assigned
Labels
area/documentation Documentation needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: use newer ysql_hba_conf_csv
3 participants
@ddorian @lizayugabyte @d-uspenskiy