Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5921 - Disable "Create Backup" if backups are disabled #6664

Merged
merged 3 commits into from
Dec 29, 2020

Conversation

gaurav061
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 15, 2020

CLA assistant check
All committers have signed the CLA.

@gaurav061
Copy link
Contributor Author

Please take a look at the current change. I have addressed the comments, Please acknowledge.

Copy link
Contributor

@andrewc-dev andrewc-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after you remove redundant ternary operator.

Copy link
Contributor

@andrewc-dev andrewc-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, thanks!

@sshev
Copy link
Collaborator

sshev commented Dec 21, 2020

Change PR title to [#5921] Platform: disable "Create Backup" if backups are disabled before merging, please.
It should follow the pattern [#1234, #1235] area: short title

@gaurav061 gaurav061 merged commit c11dc55 into master Dec 29, 2020
@gaurav061 gaurav061 deleted the 5921-diable-backup branch December 29, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants