-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#4307 Brand new arays doc. A small amount of work remains to be done. #4307
Conversation
… section structure fixed.
docs/content/latest/api/ysql/datatypes/type_array/array-constructor.md
Outdated
Show resolved
Hide resolved
docs/content/latest/api/ysql/datatypes/type_array/array-constructor.md
Outdated
Show resolved
Hide resolved
docs/content/latest/api/ysql/datatypes/type_array/array-constructor.md
Outdated
Show resolved
Hide resolved
docs/content/latest/api/ysql/datatypes/type_array/array-constructor.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot to digest, but the content is great. Make the suggested changes and this is ready to merge.
docs/content/latest/api/ysql/datatypes/type_array/array-constructor.md
Outdated
Show resolved
Hide resolved
docs/content/latest/api/ysql/datatypes/type_array/array-constructor.md
Outdated
Show resolved
Hide resolved
docs/content/latest/api/ysql/datatypes/type_array/array-constructor.md
Outdated
Show resolved
Hide resolved
docs/content/latest/api/ysql/datatypes/type_array/array-constructor.md
Outdated
Show resolved
Hide resolved
docs/content/latest/api/ysql/datatypes/type_array/array-constructor.md
Outdated
Show resolved
Hide resolved
docs/content/latest/api/ysql/datatypes/type_array/literals/text-typecasting-and-literals.md
Outdated
Show resolved
Hide resolved
docs/content/latest/api/ysql/datatypes/type_array/literals/text-typecasting-and-literals.md
Outdated
Show resolved
Hide resolved
docs/content/latest/api/ysql/datatypes/type_array/literals/text-typecasting-and-literals.md
Outdated
Show resolved
Hide resolved
docs/content/latest/api/ysql/datatypes/type_array/literals/text-typecasting-and-literals.md
Outdated
Show resolved
Hide resolved
docs/content/latest/api/ysql/datatypes/type_array/literals/text-typecasting-and-literals.md
Outdated
Show resolved
Hide resolved
…uctor.md Co-authored-by: Steve Bang <[email protected]>
…uctor.md Co-authored-by: Steve Bang <[email protected]>
…uctor.md Co-authored-by: Steve Bang <[email protected]>
…uctor.md Co-authored-by: Steve Bang <[email protected]>
…uctor.md Co-authored-by: Steve Bang <[email protected]>
…uctor.md Co-authored-by: Steve Bang <[email protected]>
…uctor.md Co-authored-by: Steve Bang <[email protected]>
…t-typecasting-and-literals.md Co-authored-by: Steve Bang <[email protected]>
…t-typecasting-and-literals.md Co-authored-by: Steve Bang <[email protected]>
…t-typecasting-and-literals.md Co-authored-by: Steve Bang <[email protected]>
…t-typecasting-and-literals.md Co-authored-by: Steve Bang <[email protected]>
…erators/_index.md Co-authored-by: Steve Bang <[email protected]>
…erators/properties.md Co-authored-by: Steve Bang <[email protected]>
…erators/replace-a-value.md Co-authored-by: Steve Bang <[email protected]>
…erators/slice-operator.md Co-authored-by: Steve Bang <[email protected]>
…erators/string-to-array.md Co-authored-by: Steve Bang <[email protected]>
…dex.md Co-authored-by: Steve Bang <[email protected]>
…dex.md Co-authored-by: Steve Bang <[email protected]>
…dex.md Co-authored-by: Steve Bang <[email protected]>
…dex.md Co-authored-by: Steve Bang <[email protected]>
…dex.md Co-authored-by: Steve Bang <[email protected]>
…dex.md Co-authored-by: Steve Bang <[email protected]>
…ay-of-rows.md Co-authored-by: Steve Bang <[email protected]>
…ay-of-rows.md Co-authored-by: Steve Bang <[email protected]>
…ay-of-rows.md Co-authored-by: Steve Bang <[email protected]>
…ay-of-rows.md Co-authored-by: Steve Bang <[email protected]>
…ay-of-rows.md Co-authored-by: Steve Bang <[email protected]>
…erators/array-agg-unnest.md Co-authored-by: Steve Bang <[email protected]>
…erators/comparison.md Co-authored-by: Steve Bang <[email protected]>
…erators/comparison.md Co-authored-by: Steve Bang <[email protected]>
…erators/comparison.md Co-authored-by: Steve Bang <[email protected]>
…erators/comparison.md Co-authored-by: Steve Bang <[email protected]>
…erators/comparison.md Co-authored-by: Steve Bang <[email protected]>
…erators/comparison.md Co-authored-by: Steve Bang <[email protected]>
…erators/comparison.md Co-authored-by: Steve Bang <[email protected]>
…erators/comparison.md Co-authored-by: Steve Bang <[email protected]>
…erators/comparison.md Co-authored-by: Steve Bang <[email protected]>
…erators/comparison.md Co-authored-by: Steve Bang <[email protected]>
Closing this now. It acted as the vehicle for excellent feedback from @stevebang and @m-iancu. But has now served its purpose. For various reasons, I'll create a brand new PR for the now-completed work. |
Work remaining:
Add the explanations and code examples for the
array[]
constructor and thestring_to_array()
function. (Already prepared in draft.)Finish the two sections “The literal for a ‘row’ type value” and “The literal for an array of ‘row’ type values”. (I have the material in draft.)
Add a code example for
unnest
on a multidimensional array.Show how to iterate over array values in PL/pgSQL using the
foreach
keyword.Proof-read every file.
Re-check every code-example by copy-and-paste into ysqlsh. In particular, check that the results in the doc are correctly copied from the ysqlsh output.
Run the spell-checker on each file.
I’d expect to finish this before anyone finishes their review.