Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4307 Brand new arays doc. A small amount of work remains to be done. #4307

Closed
wants to merge 152 commits into from
Closed

#4307 Brand new arays doc. A small amount of work remains to be done. #4307

wants to merge 152 commits into from

Conversation

bllewell
Copy link
Contributor

Work remaining:

  1. Add the explanations and code examples for the array[] constructor and the string_to_array() function. (Already prepared in draft.)

  2. Finish the two sections “The literal for a ‘row’ type value” and “The literal for an array of ‘row’ type values”. (I have the material in draft.)

  3. Add a code example for unnest on a multidimensional array.

  4. Show how to iterate over array values in PL/pgSQL using the foreach keyword.

  5. Proof-read every file.

  6. Re-check every code-example by copy-and-paste into ysqlsh. In particular, check that the results in the doc are correctly copied from the ysqlsh output.

  7. Run the spell-checker on each file.

I’d expect to finish this before anyone finishes their review.

@bllewell bllewell assigned m-iancu and stevebang and unassigned m-iancu and stevebang Apr 27, 2020
@bllewell bllewell requested review from stevebang and m-iancu April 27, 2020 23:52
@stevebang stevebang added the area/documentation Documentation needed label Apr 28, 2020
Copy link
Contributor

@stevebang stevebang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot to digest, but the content is great. Make the suggested changes and this is ready to merge.

bllewell and others added 13 commits May 4, 2020 18:27
…t-typecasting-and-literals.md

Co-authored-by: Steve Bang <[email protected]>
…t-typecasting-and-literals.md

Co-authored-by: Steve Bang <[email protected]>
…t-typecasting-and-literals.md

Co-authored-by: Steve Bang <[email protected]>
…t-typecasting-and-literals.md

Co-authored-by: Steve Bang <[email protected]>
bllewell and others added 26 commits May 5, 2020 11:10
…erators/array-agg-unnest.md

Co-authored-by: Steve Bang <[email protected]>
@bllewell
Copy link
Contributor Author

bllewell commented May 6, 2020

Closing this now. It acted as the vehicle for excellent feedback from @stevebang and @m-iancu. But has now served its purpose. For various reasons, I'll create a brand new PR for the now-completed work.

@bllewell bllewell closed this May 6, 2020
@bllewell bllewell changed the title Brand new arays doc. A small amount of work remains to be done. #4307 Brand new arays doc. A small amount of work remains to be done. Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants