alter table of parent geo-partitioned table affects select on child

[kerneljake]

ALTER TABLE on the parent geo-partitioned table affects SELECT on the child table.

The following example uses the schema from the documentation.

% ysqlsh
ysqlsh (11.2-YB-2.7.2.0-b0)

localhost:5433 yugabyte@yugabyte=# alter table transactions add column foo varchar(30);
ALTER TABLE

localhost:5433 yugabyte@yugabyte=# \d transactions_eu;
                        Table "public.transactions_eu"
    Column     |            Type             | Collation | Nullable | Default
---------------+-----------------------------+-----------+----------+---------
 user_id       | integer                     |           | not null |
 account_id    | integer                     |           | not null |
 geo_partition | character varying           |           | not null |
 account_type  | character varying           |           | not null |
 amount        | numeric                     |           | not null |
 txn_type      | character varying           |           | not null |
 created_at    | timestamp without time zone |           | not null | now()
 foo           | character varying(30)       |           |          |
Partition of: transactions FOR VALUES IN ('EU', 'EMEA')
Indexes:
    "transactions_eu_pkey" PRIMARY KEY, lsm ((user_id, geo_partition) HASH, account_id, created_at)
Tablespace: "eu_tablespace"

localhost:5433 yugabyte@yugabyte=# select * from transactions_eu;
ERROR:  Invalid argument: Invalid column number 8

[deeps1991]

The issue is because altering the partitioned table results in adding a column to the partitioned table, and then recursively adding a column for all the child tables. This is done correctly at the PG metadata side.
However the corresponding Yugabyte Alter command call is invoked only for the parent partitioned table:

static void                                                                     
  YBCPrepareAlterTableCmd(AlterTableCmd* cmd, Relation rel, YBCPgStatement handle,
                          int* col, bool* needsYBAlter,                           
                          YBCPgStatement* rollbackHandle)                         
  {                                                                               
      Oid relationId = RelationGetRelid(rel);                                     
      switch (cmd->subtype)                                                       
      {                                                                           
          case AT_AddColumn:                                                      
          case AT_AddColumnToView:                                                
          case AT_AddColumnRecurse:                                               
          {                                                                       
              ColumnDef* colDef = (ColumnDef *) cmd->def;                         
              Oid         typeOid;                                                
              int32       typmod;                                                 
              HeapTuple   typeTuple;                                              
              int order;                                                          
                                                                                 
              typeTuple = typenameType(NULL, colDef->typeName, &typmod);          
              typeOid = HeapTupleGetOid(typeTuple);                               
              order = RelationGetNumberOfAttributes(rel) + *col;                  
              const YBCPgTypeEntity *col_type = YBCDataTypeFromOidMod(order, typeOid);
                                                                                  
              HandleYBStatus(YBCPgAlterTableAddColumn(handle, colDef->colname,    
                                                      order, col_type));          
              ++(*col);                                                           
              ReleaseSysCache(typeTuple);                                         
              *needsYBAlter = true;                  

The fix is to add a column at the YB side for all the partitions as well in the above code.

[nitin302]

When can we expect this to be released?