Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Platform] Top slow queries table format needs to be improved #7233

Closed
andrewc-dev opened this issue Feb 12, 2021 · 0 comments
Closed

[Platform] Top slow queries table format needs to be improved #7233

andrewc-dev opened this issue Feb 12, 2021 · 0 comments
Assignees
@andrewc-dev
Labels
area/platform Yugabyte Platform area/ui All issues relating to UI/UX
Milestone
2.5.x

Comments

@andrewc-dev
Copy link
Contributor

Screen Shot 2021-02-12 at 10 54 35 AM

  1. If total_time number is very large, it causes overlap with the metric bar
  2. If the viewport width is small, the whiskers for the metric bar graphs are too close to the adjacent data cell.
@andrewc-dev andrewc-dev added the area/ui All issues relating to UI/UX label Feb 12, 2021
@andrewc-dev andrewc-dev self-assigned this Feb 12, 2021
@streddy-yb streddy-yb added this to the 2.5.x milestone Feb 16, 2021
@streddy-yb streddy-yb added the area/platform Yugabyte Platform label Feb 16, 2021
andrewc-dev pushed a commit that referenced this issue Feb 16, 2021
[#7233] Fix data format for slow query top sql statement data cells
b3a083f 
Summary:
Fix total_time number from overlapping with bar plot by changing time units if large enough. The time units consist of milliseconds, seconds, hours, and (however unlikely) hours in scientific notation.
Decrease total width of bar and whiskers plot to account for padding, preventing the graph from
"touching" the adjacent data cell.

Test Plan:
Go to portal and click a universe with an active workload. Scroll down and check the
units under "Total Exec Time" and confirm the spacing.
{F15064}

Reviewers: sshevchenko, mjoshi, ssutar

Reviewed By: ssutar

Subscribers: ui

Differential Revision: https://phabricator.dev.yugabyte.com/D10616
polarweasel pushed a commit to lizayugabyte/yugabyte-db that referenced this issue Mar 9, 2021
[yugabyte#7233] Fix data format for slow query top sql statement data…
120df56 
… cells

Summary:
Fix total_time number from overlapping with bar plot by changing time units if large enough. The time units consist of milliseconds, seconds, hours, and (however unlikely) hours in scientific notation.
Decrease total width of bar and whiskers plot to account for padding, preventing the graph from
"touching" the adjacent data cell.

Test Plan:
Go to portal and click a universe with an active workload. Scroll down and check the
units under "Total Exec Time" and confirm the spacing.
{F15064}

Reviewers: sshevchenko, mjoshi, ssutar

Reviewed By: ssutar

Subscribers: ui

Differential Revision: https://phabricator.dev.yugabyte.com/D10616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewc-dev andrewc-dev

Labels
area/platform Yugabyte Platform area/ui All issues relating to UI/UX
Projects
None yet
Milestone
2.5.x
Development

No branches or pull requests
2 participants
@andrewc-dev @streddy-yb