Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ysql: use all rather than 0.0.0.0/0, ::0/0 in hba conf #6784

Closed
jaki opened this issue Jan 5, 2021 · 5 comments
Closed

ysql: use all rather than 0.0.0.0/0, ::0/0 in hba conf #6784

jaki opened this issue Jan 5, 2021 · 5 comments
Labels
area/ysql Yugabyte SQL (YSQL) good first issue This is a good issue to start contributing! help wanted We welcome your contributions for this issue! kind/enhancement This is an enhancement of an existing feature size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Comments

@jaki
Copy link
Contributor

jaki commented Jan 5, 2021

From https://www.postgresql.org/docs/11/auth-pg-hba-conf.html,

0.0.0.0/0 represents all IPv4 addresses, and ::0/0 represents all IPv6 addresses.

You can also write all to match any IP address

"all" is simpler and only takes one line, so we should switch to that. This involves the default HBA config in src/yb/yql/pgwrapper/pg_wrapper.cc WritePgHbaConfig and docs. Docs should be done separately (maybe create a separate issue to track it).
@jaki jaki added kind/enhancement This is an enhancement of an existing feature help wanted We welcome your contributions for this issue! good first issue This is a good issue to start contributing! area/ysql Yugabyte SQL (YSQL) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 5, 2021
@pratikSethi
Copy link
Contributor

Hi @jaki, I would like to work on this. Can I take this up?

@jaki
Copy link
Contributor Author

jaki commented Jan 19, 2021

Hi, @pratikSethi. Yes, you can.

@jaki
Copy link
Contributor Author

jaki commented Jan 29, 2021

Hi, @pratikSethi. Have you made any progress on this or plan on doing so in the next few days? If not, I'd like others to feel welcome picking this up.

@pratikSethi
Copy link
Contributor

Hi @jaki, please give me time till Monday. I intend to work on it tomorrow or day after as I usually don't get time during the weekdays. If there is no update from me by then feel free to assign it to someone else. Thanks for your patience.

pratikSethi added a commit to pratikSethi/yugabyte-db that referenced this issue Feb 1, 2021
@pratikSethi
[yugabyte#6784] ysql: use all rather than 0.0.0.0/0, ::0/0 in hba conf
b7d2d00
iSignal pushed a commit that referenced this issue Feb 11, 2021
@pratikSethi
[#6784] ysql: use all rather than 0.0.0.0/0, ::0/0 in hba conf (#7046)
784f61b 
Replaced the occurrences of 0.0.0.0/0 and ::0/0 for ipv4 and ipv6 addressing with all in hba.conf
@tedyu tedyu mentioned this issue Feb 15, 2021
Closed
@m-iancu
Copy link
Contributor

m-iancu commented Feb 26, 2021

Fixed by 784f61b.

@m-iancu m-iancu closed this as completed Feb 26, 2021
polarweasel pushed a commit to lizayugabyte/yugabyte-db that referenced this issue Mar 9, 2021
@pratikSethi
[yugabyte#6784] ysql: use all rather than 0.0.0.0/0, ::0/0 in hba conf (
3e5cab7 
yugabyte#7046)

Replaced the occurrences of 0.0.0.0/0 and ::0/0 for ipv4 and ipv6 addressing with all in hba.conf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ysql Yugabyte SQL (YSQL) good first issue This is a good issue to start contributing! help wanted We welcome your contributions for this issue! kind/enhancement This is an enhancement of an existing feature size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@m-iancu @pratikSethi @jaki