-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YCQL] index update on list after an overwrite has incorrect behavior #6735
Labels
Comments
robertsami
added a commit
that referenced
this issue
Jan 22, 2021
Summary: Previously we would not consider the write time of a collection when iterating over its children. This means we would look at children of a collection which were logically overwritten from the perspective of query layer reads and count them as valid children when determining what docdb ArrayIndex corresponds to a given cql list index. This diff fixes the logic to consider the write time of a collection and ignore children which were written before that. Test Plan: `build/latest/tests-docdb/docdb-test --gtest_filter="DocDBTests/DocDBTestWrapper.ListOverwriteAndInsertTest/0"` `build/latest/tests-docdb/docdb-test --gtest_filter="DocDBTests/DocDBTestWrapper.ListInsertAndGetTest/0"` `build/latest/tests-integration-tests/cql-test --gtest_filter="CqlTest.TestUpdateListIndexAfterOverwrite"` Reviewers: mihnea Reviewed By: mihnea Subscribers: zyu, yql, kannan, sergei, mbautin Differential Revision: https://phabricator.dev.yugabyte.com/D10255
robertsami
added a commit
that referenced
this issue
Jan 28, 2021
…ies as expired Summary: Previously we would not consider the write time of a collection when iterating over its children. This means we would look at children of a collection which were logically overwritten from the perspective of query layer reads and count them as valid children when determining what docdb ArrayIndex corresponds to a given cql list index. This diff fixes the logic to consider the write time of a collection and ignore children which were written before that. Original commit: e0643e6 / D10255 Test Plan: `build/latest/tests-docdb/docdb-test --gtest_filter="DocDBTests/DocDBTestWrapper.ListOverwriteAndInsertTest/0"` `build/latest/tests-docdb/docdb-test --gtest_filter="DocDBTests/DocDBTestWrapper.ListInsertAndGetTest/0"` `build/latest/tests-integration-tests/cql-test --gtest_filter="CqlTest.TestUpdateListIndexAfterOverwrite"` Jenkins: rebase: 2.4 Reviewers: mihnea Reviewed By: mihnea Subscribers: mbautin, sergei, kannan, yql, zyu Differential Revision: https://phabricator.dev.yugabyte.com/D10470
robertsami
added a commit
that referenced
this issue
Feb 1, 2021
…ies as expired Summary: Previously we would not consider the write time of a collection when iterating over its children. This means we would look at children of a collection which were logically overwritten from the perspective of query layer reads and count them as valid children when determining what docdb ArrayIndex corresponds to a given cql list index. This diff fixes the logic to consider the write time of a collection and ignore children which were written before that. Original commit: e0643e6 / D10255 Test Plan: `build/latest/tests-docdb/docdb-test --gtest_filter="DocDBTests/DocDBTestWrapper.ListOverwriteAndInsertTest/0"` `build/latest/tests-docdb/docdb-test --gtest_filter="DocDBTests/DocDBTestWrapper.ListInsertAndGetTest/0"` `build/latest/tests-integration-tests/cql-test --gtest_filter="CqlTest.TestUpdateListIndexAfterOverwrite"` Jenkins: rebase: 2.2 Reviewers: mihnea Reviewed By: mihnea Subscribers: mbautin, sergei, kannan, yql, zyu Differential Revision: https://phabricator.dev.yugabyte.com/D10471
polarweasel
pushed a commit
to lizayugabyte/yugabyte-db
that referenced
this issue
Mar 9, 2021
…expired Summary: Previously we would not consider the write time of a collection when iterating over its children. This means we would look at children of a collection which were logically overwritten from the perspective of query layer reads and count them as valid children when determining what docdb ArrayIndex corresponds to a given cql list index. This diff fixes the logic to consider the write time of a collection and ignore children which were written before that. Test Plan: `build/latest/tests-docdb/docdb-test --gtest_filter="DocDBTests/DocDBTestWrapper.ListOverwriteAndInsertTest/0"` `build/latest/tests-docdb/docdb-test --gtest_filter="DocDBTests/DocDBTestWrapper.ListInsertAndGetTest/0"` `build/latest/tests-integration-tests/cql-test --gtest_filter="CqlTest.TestUpdateListIndexAfterOverwrite"` Reviewers: mihnea Reviewed By: mihnea Subscribers: zyu, yql, kannan, sergei, mbautin Differential Revision: https://phabricator.dev.yugabyte.com/D10255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Test Case 1:
Test Case 2:
The text was updated successfully, but these errors were encountered: