Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform] Fix regression with backup failure email #6461

Closed
daniel-yb opened this issue Nov 23, 2020 · 0 comments
Closed

[Platform] Fix regression with backup failure email #6461

daniel-yb opened this issue Nov 23, 2020 · 0 comments
Assignees
Labels
area/platform Yugabyte Platform

Comments

@daniel-yb
Copy link
Contributor

When implementing replication lag alerting, I caused a regression with backup failure alerting. Need to fix field names in the alert payload.

@daniel-yb daniel-yb self-assigned this Nov 23, 2020
daniel-yb added a commit that referenced this issue Nov 24, 2020
Summary:
When implementing replication lag alerting, I caused a regression with backup failure alerting. Need to fix field names in the alert payload.

@CNarang noticed that emails weren't being sent when testing this feature on 2.5.1. Tested the feature on his installation of the platform and saw
```
Invalid alert_info_json
```
being logged for cluster_health.py when running it manually with the logged payload from the platform. This should resolve the issue.

Test Plan: Test backup failure alert

Reviewers: arnav, wesley, sanketh

Reviewed By: sanketh

Subscribers: cnarang, jenkins-bot, yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D9972
daniel-yb added a commit that referenced this issue Dec 5, 2020
Summary:
When implementing replication lag alerting, I caused a regression with backup failure alerting. Need to fix field names in the alert payload.

@CNarang noticed that emails weren't being sent when testing this feature on 2.5.1. Tested the feature on his installation of the platform and saw
```
Invalid alert_info_json
```
being logged for cluster_health.py when running it manually with the logged payload from the platform. This should resolve the issue.

Test Plan: Test backup failure alert

Reviewers: arnav, wesley, sanketh

Reviewed By: sanketh

Subscribers: cnarang, jenkins-bot, yugaware

Differential Revision: https://phabricator.dev.yugabyte.com/D9972
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform Yugabyte Platform
Projects
None yet
Development

No branches or pull requests

2 participants