Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] Cleanup Memory Context on File Sourced YB Relation in COPY FROM Query #5646

Closed
emhna opened this issue Sep 10, 2020 · 0 comments
Closed

[YSQL] Cleanup Memory Context on File Sourced YB Relation in COPY FROM Query #5646

emhna opened this issue Sep 10, 2020 · 0 comments
Assignees
@emhna
Labels
area/ysql Yugabyte SQL (YSQL)

Comments

@emhna
Copy link
Contributor

emhna commented Sep 10, 2020

Follow up to the Github issue #5453, clean up the row_context without depending on rows_per_transaction query option.
The context should be reset and deleted based on shouldResetMemoryPerRow flag instead.
@emhna emhna self-assigned this Sep 10, 2020
@emhna emhna added the area/ysql Yugabyte SQL (YSQL) label Sep 10, 2020
emhna added a commit that referenced this issue Sep 10, 2020
@emhna
[#5646][YSQL] Minor Fix to Cleanup Memory Context on File Sourced YBR…
34d2bc3 
…elation

Summary:
This fix is follow-up to https://phabricator.dev.yugabyte.com/D9313.
In `Copy From`, after all rows from file sourced input have been committed into YBRelation, memory context (`row_context`)
should be cleaned up on the following changed condition:
- without depending on `rows_per_transaction` query option
- must use boolean flag `shouldResetMemoryPerRow` to ensure it is YBRelation table type where its input sourced from file type (ie. not stdin).

`shouldResetMemoryPerRow` is the same flag that is used to verify whether memory context can be reset per row after being inserted into table.

Test Plan: build and reran tests

Reviewers: jason, alex

Reviewed By: jason, alex

Subscribers: yql

Differential Revision: https://phabricator.dev.yugabyte.com/D9342
@emhna emhna closed this as completed Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emhna emhna

Labels
area/ysql Yugabyte SQL (YSQL)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emhna