Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogCache is reporting memory usage on followers #3665

Closed
mbautin opened this issue Feb 15, 2020 · 1 comment
Closed

LogCache is reporting memory usage on followers #3665

mbautin opened this issue Feb 15, 2020 · 1 comment
Assignees
Labels
area/docdb YugabyteDB core features

Comments

@mbautin
Copy link
Contributor

mbautin commented Feb 15, 2020

2.0.11.0-b23 - 2d52e1d -- issue not present
2.1.0.0.-b7 - 20a1fe4 -- issue present

@mbautin mbautin self-assigned this Feb 15, 2020
@mbautin
Copy link
Contributor Author

mbautin commented Feb 15, 2020

spolitov added a commit that referenced this issue Feb 18, 2020
Summary:
After 38ef51a, we ended up not calling ResponseFromPeer
for followers. At least one of the side effects of this was that the LogCache would be filled up
when getting requests, but no longer cleared after writing them to the Log. This quickly lead to
memory issues on lower memory machines, as we assign up to 1GB of memory across all LogCache
instances.

This diff addresses the issue, by cleaning LogCache after the operation is appended to the Log.

Test Plan: ybd --gtest_filter QLStressTest.LongRemoteBootstrap

Reviewers: timur, mikhail, bogdan

Reviewed By: bogdan

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D7974
spolitov added a commit that referenced this issue Apr 17, 2020
…ter operation was appended to log

Summary:
After 38ef51a, we ended up not calling ResponseFromPeer
for followers. At least one of the side effects of this was that the LogCache would be filled up
when getting requests, but no longer cleared after writing them to the Log. This quickly lead to
memory issues on lower memory machines, as we assign up to 1GB of memory across all LogCache
instances.

This diff addresses the issue, by cleaning LogCache after the operation is appended to the Log.

Test Plan:
ybd --gtest_filter QLStressTest.LongRemoteBootstrap
Jenkins: auto rebase: no

Reviewers: timur, mikhail, bogdan

Reviewed By: bogdan

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D8312
@bmatican bmatican added the area/docdb YugabyteDB core features label Jun 25, 2020
@bmatican bmatican assigned spolitov and unassigned mbautin Jun 25, 2020
ngov17 pushed a commit to ngov17/yugabyte-db that referenced this issue Jun 26, 2020
…lower after operation was appended to log

Summary:
After 38ef51a, we ended up not calling ResponseFromPeer
for followers. At least one of the side effects of this was that the LogCache would be filled up
when getting requests, but no longer cleared after writing them to the Log. This quickly lead to
memory issues on lower memory machines, as we assign up to 1GB of memory across all LogCache
instances.

This diff addresses the issue, by cleaning LogCache after the operation is appended to the Log.

Test Plan:
ybd --gtest_filter QLStressTest.LongRemoteBootstrap
Jenkins: auto rebase: no

Reviewers: timur, mikhail, bogdan

Reviewed By: bogdan

Subscribers: ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D8312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features
Projects
None yet
Development

No branches or pull requests

3 participants