Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DocDB] TabletSplitRemoteBootstrapEnabledTest.TestSplitAfterFailedRbsCreatesDirectories fails in master #25448

Open
1 task done
spolitov opened this issue Dec 28, 2024 · 0 comments
Assignees
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature kind/failing-test Tests and testing infra priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage

Comments

@spolitov
Copy link
Contributor

spolitov commented Dec 28, 2024

Jira Link: DB-14691

Description

../../src/yb/integration-tests/tablet-split-itest.cc:2959
Failed
Bad status: Timed out (yb/util/backoff_waiter.cc:78): Operation 'Waiting for nodes to have same set of tablet metas.' didn't complete within 15000ms

Issue Type

kind/failing-test

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@spolitov spolitov added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Dec 28, 2024
@spolitov spolitov self-assigned this Dec 28, 2024
@yugabyte-ci yugabyte-ci added kind/failing-test Tests and testing infra priority/medium Medium priority issue kind/enhancement This is an enhancement of an existing feature labels Dec 28, 2024
spolitov added a commit that referenced this issue Dec 28, 2024
Summary:
When updating tablet metadata file we create temporary file, write to this file, then rename it to regular filename.
It could happen that crash happens during this process (even in a different thread).
So temporary file remains in tablet-meta folder.
Added logic to cleanup such file on server startup.

The test TabletSplitRemoteBootstrapEnabledTest.TestSplitAfterFailedRbsCreatesDirectories uses artificial crash.
So during such crash we could generate temporary tablet metadata file.
Then test waits until tablet metadata on different nodes matches, but because of temporary metadata it never matches.
Jira: DB-14691

Test Plan: ./yb_build.sh asan -n 100 --cxx-test integration-tests_tablet-split-itest --gtest_filter TabletSplitRemoteBootstrapEnabledTest.TestSplitAfterFailedRbsCreatesDirectories -- -p 8

Reviewers: timur

Reviewed By: timur

Subscribers: ybase

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D40935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature kind/failing-test Tests and testing infra priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage
Projects
None yet
Development

No branches or pull requests

2 participants