Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] resolve YB_TODO in postinit.c #25446

Open
1 task done
myang2021 opened this issue Dec 27, 2024 · 0 comments
Open
1 task done

[YSQL] resolve YB_TODO in postinit.c #25446

myang2021 opened this issue Dec 27, 2024 · 0 comments
Assignees
@myang2021
Labels
area/ysql Yugabyte SQL (YSQL) kind/new-feature This is a request for a completely new feature kind/question This is a question priority/medium Medium priority issue

Comments

@myang2021
Copy link
Contributor

myang2021 commented Dec 27, 2024 •
edited by jira bot
Loading

Jira Link: DB-14689

Description

There is one YB_TODO in postinit.c:

/* YB_TODO(neil) Double check the merged in this file.
 * Both Postgres and Yb refactor code, so merging mistakes are possible.
 * NOTE: Latest change in master might not be merged. Check "YB::master" code again for new changes.
 */

Issue Type

kind/question

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@myang2021 myang2021 added the area/ysql Yugabyte SQL (YSQL) label Dec 27, 2024
@myang2021 myang2021 self-assigned this Dec 27, 2024
@yugabyte-ci yugabyte-ci added kind/question This is a question priority/medium Medium priority issue kind/new-feature This is a request for a completely new feature labels Dec 27, 2024
myang2021 added a commit that referenced this issue Jan 6, 2025
@myang2021
[#25446] YSQL: resolve YB_TODO in postinit.c
ebd5963 
Summary:
The YB_TODO in postinit.c mentions possible merge conflicts. After reviewing the
YB changes, I found they are fine because they are either
(1) new YB specific code inserted, or
(2) PG code skipped in YB environment.

I renamed the YB argument `session_id` to `yb_session_id`. Also added one
additional `if (IsYugaByteEnabled())` to make YB specific code a bit clearer.
Jira: DB-14689

Test Plan: jenkins

Reviewers: kfranz, mihnea

Reviewed By: kfranz

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D40930
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@myang2021 myang2021

Labels
area/ysql Yugabyte SQL (YSQL) kind/new-feature This is a request for a completely new feature kind/question This is a question priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yugabyte-ci @myang2021