Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DocDB] Fix Unit Test Errors Caused by Inconsistent Table ID and Table Name #25423

Open
1 task done
yusong-yan opened this issue Dec 24, 2024 · 0 comments
Open
1 task done
Assignees
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage

Comments

@yusong-yan
Copy link
Contributor

yusong-yan commented Dec 24, 2024

Jira Link: DB-14655

Description

A new DCHECK, introduced as part of this pending work, ensures that all metrics sharing the same table_id have the same table_name. However, during testing, this DCHECK revealed several inconsistencies in existing unit tests where mismatches between table_id and table_name were found. These are test only issue and need to be corrected by assigning proper table_id and table_name values.

Issue Type

kind/bug

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@yusong-yan yusong-yan added area/docdb YugabyteDB core features status/awaiting-triage Issue awaiting triage labels Dec 24, 2024
@yusong-yan yusong-yan self-assigned this Dec 24, 2024
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Dec 24, 2024
yusong-yan added a commit that referenced this issue Dec 26, 2024
…ame in Metric Attributes

Summary:
A new DCHECK, introduced as part of D39667(pending work), checks pre-aggregated metric's attributes to ensures that all metrics sharing the same table_id have the same table_name. However, during testing, this DCHECK revealed several inconsistencies in existing unit tests where mismatches between table_id and table_name were found. These are test only issue and need to be corrected by assigning proper table_id and table_name values.
Jira: DB-14655

Test Plan: Jenkins

Reviewers: amitanand, xCluster, hsunder

Reviewed By: amitanand

Subscribers: ybase, rthallam

Differential Revision: https://phorge.dev.yugabyte.com/D40875
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features kind/bug This issue is a bug priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage
Projects
None yet
Development

No branches or pull requests

2 participants