Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL][ASH] Handle interrupts in ASH collector in a better way #24582

Closed
1 task done
abhinab-yb opened this issue Oct 23, 2024 · 0 comments
Closed
1 task done

[YSQL][ASH] Handle interrupts in ASH collector in a better way #24582

abhinab-yb opened this issue Oct 23, 2024 · 0 comments
Assignees
@abhinab-yb
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@abhinab-yb
Copy link
Contributor

abhinab-yb commented Oct 23, 2024 •
edited by jira bot
Loading

Jira Link: DB-13621

Description

PG 15 has introduced a new function HandleMainLoopInterrupts to handle interrupts, try to use that

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@abhinab-yb abhinab-yb added the area/ysql Yugabyte SQL (YSQL) label Oct 23, 2024
@abhinab-yb abhinab-yb self-assigned this Oct 23, 2024
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Oct 23, 2024
abhinab-yb added a commit that referenced this issue Nov 4, 2024
@abhinab-yb
[#24582] YSQL, ASH: Handle more interrupts in ASH collector
6e87f27 
Summary:
PG 15 added a new interrupt ProcSignalBarrierPending which is
set to true after certain queries, ProcessProcSignalBarrier()
must be called, otherwise ASH collector is stuck, as seen by
the PgWaitEventAuxTest.NewDatabaseRPCs test.

This test was created before PG 15 merge, and skipped
when D38309 / 72fc467
was landed with PG 15 changes.

Summary of changes -
- Remove signal handlers defined in yb_ash.h
- Add signal handlers for SIGINT and SIGQUIT too
- Use HandleMainLoopInterrupts to handle signals

Jira: DB-13621

Test Plan:
Jenkins

./yb_build.sh --cxx-test pg_ash-test --gtest_filter *NewDatabaseRPCs

Reviewers: jason

Reviewed By: jason

Subscribers: amitanand, hbhanawat, yql

Differential Revision: https://phorge.dev.yugabyte.com/D39533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhinab-yb abhinab-yb

Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yugabyte-ci @abhinab-yb