[DocDB] Fix --gcc13 compilation issue #24011
Assignees
Labels
area/docdb
YugabyteDB core features
kind/bug
This issue is a bug
priority/medium
Medium priority issue
Comments
andrei-mart
added
area/docdb
yugabyte-ci
added
kind/bug
andrei-mart
added a commit
that referenced
this issue
Sep 18, 2024
Summary:
GCC13 detects "nodiscard" attribute violation:
```
/-------------------------------------------------------------------------------
| COMPILATION FAILED
|-------------------------------------------------------------------------------
../../src/yb/rocksdb/utilities/checkpoint/checkpoint.cc: In function ‘rocksdb::Status rocksdb::checkpoint::CreateCheckpoint(rocksdb::DB*, const std::string&)’:
../../src/yb/rocksdb/utilities/checkpoint/checkpoint.cc:177:62: error: ignoring return value of ‘constexpr const _CharT* std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::c_str() const [with _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]’, declared with attribute ‘nodiscard’ [-Werror=unused-result]
177 | VLOG(1) << "Deleted dir %s -- %s", checkpoint_dir.c_str(), s_del.ToString().c_str();
| ~~~~~~~~~~~~~~~~~~~~^~
In file included from /usr/include/c++/13/string:54,
from ../../src/yb/rocksdb/utilities/checkpoint.h:24,
from ../../src/yb/rocksdb/utilities/checkpoint/checkpoint.cc:25:
/usr/include/c++/13/bits/basic_string.h:2595:7: note: declared here
2595 | c_str() const _GLIBCXX_NOEXCEPT
| ^~~~~
../../src/yb/rocksdb/utilities/checkpoint/checkpoint.cc:177:88: error: ignoring return value of ‘constexpr const _CharT* std::__cxx11::basic_string<_CharT, _Traits, _Alloc>::c_str() const [with _CharT = char; _Traits = std::char_traits<char>; _Alloc = std::allocator<char>]’, declared with attribute ‘nodiscard’ [-Werror=unused-result]
177 | VLOG(1) << "Deleted dir %s -- %s", checkpoint_dir.c_str(), s_del.ToString().c_str();
| ~~~~~~~~~~~~~~~~~~~~~~^~
/usr/include/c++/13/bits/basic_string.h:2595:7: note: declared here
2595 | c_str() const _GLIBCXX_NOEXCEPT
| ^~~~~
cc1plus: all warnings being treated as errors
Input files:
/home/amartsin/code/yugabyte-db/build/debug-gcc13-dynamic-ninja/src/yb/rocksdb/CMakeFiles/rocksdb.dir/utilities/checkpoint/checkpoint.cc.o
/home/amartsin/code/yugabyte-db/src/yb/rocksdb/utilities/checkpoint/checkpoint.cc
Output file (from -o): src/yb/rocksdb/CMakeFiles/rocksdb.dir/utilities/checkpoint/checkpoint.cc.o
\-------------------------------------------------------------------------------
```
Jira: DB-12898
Test Plan: Jenkins: compile only
Reviewers: asrivastava
Reviewed By: asrivastava
Subscribers: ybase, yql
Tags: #jenkins-ready
Differential Revision: https://phorge.dev.yugabyte.com/D38172
foucher
added a commit
that referenced
this issue
Sep 20, 2024
Summary: 6b34652 [doc] Update badge colors (#23985) 6dcfce6 [PLAT-15297][dr] GET /configs fails with java.lang.IllegalStateException: DrConfig iTest-dr(uuid) does not have any corresponding xCluster config 7995311 [#23695] docdb: Improve help strings for tablet replica limit flags. 7659151 [DOC-479] Voyager 1.8.1 updates (#23983) 56c9cc9 [PLAT-15282]: fix NPE on k8s operator backup/restore status update c8776b5 [docs] SSL/TLS configuration with hashicorp vault YSQL plugin (#23979) Excluded: d3dd4f7 Bumping version to 2.25.0.0 on branch master Excluded: 0dbe7d6 [#23312] YSQL: Fix backup/restore for colocated tables without tablespace information. 2beb872 [#23786] YSQL: add yb_make_next_ddl_statement_nonincrementing to YbDbAdminVariables 28d0d8e [#24011] build: fix ./yb_build.sh --gcc13 9feb6e8 [#24012] YSQL: Replace deprecated function shared_ptr::unique to fix macos compiler error 2cc1480 [PLAT-15349] Fix update_lb_config automated NLB updates af4c46d [#23741] docdb: Add parameter to run PITR tests with clone instead 0103dfc [PLAT-14459] Continuous backups for s3 e6bb890 [PLAT-15192] [PLAT-15191] Document node-agent-provision.yaml 1552321 [PLAT-15205] YBA callhome improvements ba6acbd [PLAT-15342] Install Node Agent as root level unit for ynp 2478a50 [PLAT-13058] Remove references to public key filepath, since we don't need ssh keys for node agent based provisioning aa14f76 [#23975] YSQL, ASH: Fix TestYbAsh#testPgAuxInfo 885b72b [#23960] DocDB: Fix WriteBuffer crash in move ctor Excluded: f4a002a [#23314] YSQL: Fix variable name to yb_ for ATPrepSetTableSpace 29c56ed [PLAT-15369][YBA CLI]Backup list-increments doesn't support pretty/json outputs 784160c [PLAT-15370][YBA CLI]backup list table output contains base_backup_uuid and backup_uuid b32222d [PLAT-15280][PLAT-14753] - Pg parity improvements and other ui fixes c6521cf [PLAT-15368][YBA CLI]Backup list print "No more backup present" after printing all the backups in -o pretty/json - pg_catalog_version-test.cc - NonIncrementingDDLMode: YB master commit 2beb872 sets the role to yb_db_admin, which due to new behavior in upstream PG commit b073c3ccd06e4cb845e121387a43faa8c68a7b62 (documented in https://www.postgresql.org/docs/15/ddl-schemas.html#DDL-SCHEMAS-PATTERNS) causes the following unintended test failure: ERROR: permission denied for schema public. Add a workaround to grant create permission to the role now set. Test Plan: Jenkins: urgent, rebase: pg15-cherrypicks Reviewers: jason, jenkins-bot Differential Revision: https://phorge.dev.yugabyte.com/D38220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-12898
Description
GCC13 detects "nodiscard" attribute violation:
Issue Type
kind/bug
Warning: Please confirm that this issue does not contain any sensitive information
The text was updated successfully, but these errors were encountered: