Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yugabyted] UI is displaying incorrect disk size when multiple data directories are given #23810

Closed
1 task done
nchandrappa opened this issue Sep 5, 2024 · 0 comments
Closed
1 task done
Assignees
Labels
kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@nchandrappa
Copy link
Contributor

nchandrappa commented Sep 5, 2024

Jira Link: DB-12711

Description

When multiple data directories are given with yugabyted start --data_dirs /mnt/disk1,/mnt/disk2, the UI is only showing the disk size of one of the directories. This needs to be fixed.

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@nchandrappa nchandrappa added status/awaiting-triage Issue awaiting triage area/ybd yugabyted project related Github tickets. labels Sep 5, 2024
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Sep 5, 2024
@yugabyte-ci yugabyte-ci removed the area/ybd yugabyted project related Github tickets. label Sep 16, 2024
krishna-yb added a commit that referenced this issue Sep 25, 2024
…iple data directories

Summary: Initially because of QUERY_LIMIT_ONE, the cql iterator was iterating over a single row, now using for loop multiple rows are accessed and hence total value of disk size and free_disk can be evaluated even in case of multiple directories system. Here metrics_snapshotter_interval_ms tserver flag is used for interval time value and for from (MOST_RECENT_TIMESTAMP-interval/2) till now all values are added up for fetching the correct value.

Test Plan: Manual Testing

Reviewers: sgarg-yb, nikhil

Reviewed By: nikhil

Subscribers: yugabyted-dev, krishna.tripathi

Differential Revision: https://phorge.dev.yugabyte.com/D38313
timothy-e pushed a commit that referenced this issue Sep 26, 2024
Summary:
 35b12d2 [PLAT-15404] Average YSQL operations latency alert is using incorrect units (ms vs microsecs)
 Excluded: 008f885 [#23788] YSQL, QueryDiagnostics: Fixing issues in pg_stat_statements when no query executed
 6ca8cc4 [#23810] yugabyted-ui: UI is displaying incorrect disk size when multiple data directories
 dca5923 [PLAT-15034][K8s] Add changes to apply master_join_existing_cluster gflag
 fa9b370 [docs] Update content for getting started page for CDC logical replication (#23916)
 8db0ffb [PLAT-15380] clock drift alert did not reference nodes
 44ae377 [PLAT-15349] Mark universe update as success after update lb config
 Excluded: 9f90819 [#24121] xCluster: Fix xcluster_outbound_replication_group-itest TestGetStreamByTableId
 250a4d5 [#24026] docdb: Fix SIGSEGV from MaxPersistentOpId after flush
 0d1046a [DEVOPS-3238] Move macOS build to macos13 (Ventura)
 87cffc6 [#24137] DocDB: Add gflag_allowlist to yb_release_manifest
 678d277 [#21178] docdb: Add metric for the max master follower heartbeat delay.
 ff97f51 [doc][ybm] Certificate links (#24139)
 Excluded: d26b62d [#21733] YSQL: ParallelAppend and pg_hint_plan
 3ffe5a7 [PLAT-10519]Lack of Client-Side Inactivity Timeout - Part 1
 254e164 [PLAT-15432] remove status,sizeInBytes from manifest.json file

Test Plan: Jenkins: rebase: pg15-cherrypicks

Reviewers: tfoucher, fizaa, telgersma

Differential Revision: https://phorge.dev.yugabyte.com/D38454
@yugabyte-ci yugabyte-ci removed the status/awaiting-triage Issue awaiting triage label Oct 5, 2024
krishna-yb added a commit that referenced this issue Oct 10, 2024
…sk size when multiple data directories

Summary:
Initially because of QUERY_LIMIT_ONE, the cql iterator was iterating over a single row, now using for loop multiple rows are accessed and hence total value of disk size and free_disk can be evaluated even in case of multiple directories system. Here metrics_snapshotter_interval_ms tserver flag is used for interval time value and for from (MOST_RECENT_TIMESTAMP-interval/2) till now all values are added up for fetching the correct value.

Original commit: 6ca8cc4 / D38313

Test Plan: Manual Testing

Reviewers: nikhil

Reviewed By: nikhil

Subscribers: krishna.tripathi, yugabyted-dev

Differential Revision: https://phorge.dev.yugabyte.com/D38901
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

3 participants