[YSQL] Metrics with no name appear on :13000/prometheus-metrics #23557
Assignees
Labels
Comments
kai-franz
added
area/ysql
yugabyte-ci
added
kind/bug
kai-franz
added a commit
that referenced
this issue
Aug 20, 2024
Summary:
`PgPrometheusMetricsHandler` is treating `CatCacheMisses_End` in the `statementType` enum as a metric and publishes these empty metric names:
```
_count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="yb-15-kfranz-catcache-chart-1-n1"} 0 1723844460867
_sum{metric_id="yb.ysqlserver",metric_type="server",exported_instance="yb-15-kfranz-catcache-chart-1-n1"} 0 1723844460867
```
This revision fixes that behavior, removing the empty metrics.
Test Plan:
```
./yb_build.sh --cxx-test pgwrapper_pg_libpq-test --gtest_filter PgLibPqTest.CatalogCacheIdMissMetricsTest
```
Reviewers: myang
Reviewed By: myang
Subscribers: yql
Differential Revision: https://phorge.dev.yugabyte.com/D37372
kai-franz
added a commit
that referenced
this issue
Aug 20, 2024
Summary: Original commit: 6daf129 / D37372 `PgPrometheusMetricsHandler` is treating `CatCacheMisses_End` in the `statementType` enum as a metric and publishes these empty metric names: ``` _count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="yb-15-kfranz-catcache-chart-1-n1"} 0 1723844460867 _sum{metric_id="yb.ysqlserver",metric_type="server",exported_instance="yb-15-kfranz-catcache-chart-1-n1"} 0 1723844460867 ``` This revision fixes that behavior, removing the empty metrics. Test Plan: ``` ./yb_build.sh --cxx-test pgwrapper_pg_libpq-test --gtest_filter PgLibPqTest.CatalogCacheIdMissMetricsTest ``` Reviewers: myang Reviewed By: myang Subscribers: yql Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D37396
jasonyb
pushed a commit
that referenced
this issue
Aug 21, 2024
Summary: feb7ddd [#23524] DocDB: Implement VectorIndexFetcher by VectorIndexUpdate 5b21f96 Add content for gin_trgm_ops (#23528) 5878518 [docs] renamed references (#23212) 67147d2 [PLAT-14993] Clean out pg_data_11 dir on onprem node release/delete Excluded: 6daf129 [#23557] Remove empty CatCacheIdMisses_End metric d0d8535 [PLAT-14960] make ssh key optional for onprem manual provisioning 54776ab [DB-10610] YSQL: import Detect integer overflow while computing new array dimensions Excluded: 1a3c113 [#19131] YSQL, ASH: Create a view to display wait events information Test Plan: Jenkins: rebase: pg15-cherrypicks Reviewers: jason, tfoucher Tags: #jenkins-ready Differential Revision: https://phorge.dev.yugabyte.com/D37421
kai-franz
added a commit
that referenced
this issue
Aug 23, 2024
… metric Summary: Original commit: 6daf129 / D37372 - yb_pg_metrics.c: - enum statementType: YB master 6daf129 sets CatCacheIdMisses_End to CatCacheIdMisses_78. Adapt according to YB pg15 merge 602cb2d, accounting for 6 additional catcache entries. `PgPrometheusMetricsHandler` is treating `CatCacheMisses_End` in the `statementType` enum as a metric and publishes these empty metric names: ``` _count{metric_id="yb.ysqlserver",metric_type="server",exported_instance="yb-15-kfranz-catcache-chart-1-n1"} 0 1723844460867 _sum{metric_id="yb.ysqlserver",metric_type="server",exported_instance="yb-15-kfranz-catcache-chart-1-n1"} 0 1723844460867 ``` This revision fixes that behavior, removing the empty metrics. Test Plan: ``` ./yb_build.sh --cxx-test pgwrapper_pg_libpq-test --gtest_filter PgLibPqTest.CatalogCacheIdMissMetricsTest ``` Reviewers: jason, tfoucher Reviewed By: jason Subscribers: yql Differential Revision: https://phorge.dev.yugabyte.com/D37442
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira Link: DB-12475
Description
On the YSQL Metrics endpoint, we are seeing a metric without a name:
Issue Type
kind/bug
Warning: Please confirm that this issue does not contain any sensitive information
The text was updated successfully, but these errors were encountered: