Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tools] Remove function CallVisitor() from the sys-catalog-tool code #23548

Closed
1 task done
OlegLoginov opened this issue Aug 19, 2024 · 0 comments
Closed
1 task done
Assignees
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue

Comments

@OlegLoginov
Copy link
Contributor

OlegLoginov commented Aug 19, 2024

Jira Link: DB-12466

Description

After the previous commit: D37013 /
https://phorge.dev.yugabyte.com/rYBDB5148b31fd3620a6f4aacf2ee6089d7fa6a8b2faa

The CallVisitor() template function is not needed more and can be removed to clean-up & simplify the code of the tool.

Issue Type

kind/enhancement

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@OlegLoginov OlegLoginov added the area/docdb YugabyteDB core features label Aug 19, 2024
@OlegLoginov OlegLoginov self-assigned this Aug 19, 2024
@yugabyte-ci yugabyte-ci added kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue labels Aug 19, 2024
OlegLoginov added a commit that referenced this issue Aug 20, 2024
Summary:
Previous commit: D37013 / 5148b31

Let's remove `CallVisitor` template function because it's not needed more.
Jira: DB-12466

Test Plan: Jenkins + manual testing

Reviewers: mihnea, hsunder

Reviewed By: hsunder

Subscribers: ybase, yql

Differential Revision: https://phorge.dev.yugabyte.com/D37344
jasonyb pushed a commit that referenced this issue Aug 22, 2024
Summary:
 0fa2b24 Fix table layout to utilize maximum available space (#23564)
 336d00d [PLAT-14981]Increase default slow  query length
 e5127f8 [DOC-445] TA-22935: Potential Issues with Server-side Sequence Caching in Multi-Database Clusters (#23520)
 b3389ff [#23493] xCluster: code for ensuring there's an update for every sequence in WAL
 cb26a09 [#23548] Tools: Clean-up sys-catalog-tool code
 28025f6 [docs] Visualize migration assessment updates (#23358)
 9c0de5d [#23257] YSQL: Change conflict error string for RC transactions
 507432b [#23523] docdb: retryable requests instrumentation
 e4645e5 [DOC-431] Added a note for GKE cluster docs (#23349)
 d1576c4 [PLAT-12905] Add HA Metrics Page
 02da1f0 [PLAT-14869][PLAT-14986][PLAT-14998][PLAT-15003] - ui improvements and fixes
 c149f26 [#23556] hnsw_tool command-line tool for testing HNSW index implementations
 7725f15 Add operator mode & task info to diagnostics
 e193fc6 Revert "[#23064] YSQL: pg_partman: disable p_retention_schema parameter"
 8178372 [#23513] YSQL: Simplify several functions in ybc_pggate
 22657da [#23394] CDCSDK: Prevent tserver crash on concurrent Getchanges call on same producer tablet
 90554b0 [#23179] CDCSDK: Refactor TestPgReplicationSlot for dynamic data types

Test Plan: Jenkins: rebase: pg15-cherrypicks

Reviewers: jason, tfoucher

Differential Revision: https://phorge.dev.yugabyte.com/D37453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docdb YugabyteDB core features kind/enhancement This is an enhancement of an existing feature priority/medium Medium priority issue
Projects
None yet
Development

No branches or pull requests

2 participants