Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YSQL] TestPgAuthorization full test fails #23295

Closed
1 task done
jasonyb opened this issue Jul 26, 2024 · 1 comment
Closed
1 task done

[YSQL] TestPgAuthorization full test fails #23295

jasonyb opened this issue Jul 26, 2024 · 1 comment
Assignees
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature kind/failing-test Tests and testing infra priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage

Comments

@jasonyb
Copy link
Contributor

jasonyb commented Jul 26, 2024

Jira Link: DB-12216

Description

./yb_build.sh fastdebug --gcc11 --java-test org.yb.pgsql.TestPgAuthorization gets

ERROR: role "yb_db_admin_member" already exists

because commit 399f165 introduces test testPgLocksAuthorization that creates yb_db_admin_member when there already exists another test testSessionAuthorization that creates that role and doesn't drop it.

Issue Type

kind/failing-test

Warning: Please confirm that this issue does not contain any sensitive information

  • I confirm this issue does not contain any sensitive information.
@jasonyb jasonyb added area/ysql Yugabyte SQL (YSQL) status/awaiting-triage Issue awaiting triage labels Jul 26, 2024
@yugabyte-ci yugabyte-ci added kind/failing-test Tests and testing infra priority/medium Medium priority issue kind/enhancement This is an enhancement of an existing feature labels Jul 26, 2024
pao214 added a commit that referenced this issue Jul 29, 2024
… is run.

Summary:
Role yb_db_admin_member is already created in testSessionAuthorization.
Need a newly named role for the testPgLocksAuthorization case.
Jira: DB-12216

Test Plan:
Jenkins

Jenkins will not catch this since this only manifests in a full run.

```
./yb_build.sh --java-test TestPgAuthorization
```

Backport-through: 2.20

Reviewers: jason

Reviewed By: jason

Differential Revision: https://phorge.dev.yugabyte.com/D36869
jasonyb pushed a commit that referenced this issue Jul 29, 2024
…ter-merge

Merge YB master commit 7fef119 titled

    [PLAT-13956]: Add an RBAC action role for xCluster/DR

and committed 2024-07-26T13:25:38+00:00 into YB pg15.

- pg_dump.c:
  - dumpACL:
    - variable declarations of if (sql->len > 0): YB master
      7414711 renames use_roles_sql to
      yb_use_roles_sql.  Upstream PG
      ea9125304dc6e90eabad165bd120eb1e667525d4 adds aclDeps and nDeps.
      Adjacent conflict.
    - ArchiveEntry call: YB master
      7414711 does a similar rename for
      one of the arguments.  Upstream PG
      f831d4accda00b9144bc647ede2e2f848b59f39d changes the format of the
      arguments.  Merge.
- pg15_tests/passing_tests.tsv:
  - remove org.yb.pgsql.TestPgAuthorization from the list because of
    issue #23295.
jasonyb pushed a commit that referenced this issue Jul 29, 2024
…522e150' into pg15

Summary:
Merge YB master commit 7fef119 titled

    [PLAT-13956]: Add an RBAC action role for xCluster/DR

and committed 2024-07-26T13:25:38+00:00 into YB pg15.

- pg_dump.c:
  - dumpACL:
    - variable declarations of if (sql->len > 0): YB master
      7414711 renames use_roles_sql to
      yb_use_roles_sql.  Upstream PG
      ea9125304dc6e90eabad165bd120eb1e667525d4 adds aclDeps and nDeps.
      Adjacent conflict.
    - ArchiveEntry call: YB master
      7414711 does a similar rename for
      one of the arguments.  Upstream PG
      f831d4accda00b9144bc647ede2e2f848b59f39d changes the format of the
      arguments.  Merge.
- pg15_tests/passing_tests.tsv:
  - remove org.yb.pgsql.TestPgAuthorization from the list because of
    issue #23295.

Test Plan:
On Almalinux 8:

    #!/usr/bin/env bash
    set -eu
    ./yb_build.sh fastdebug --gcc11
    TZ=UTC pg15_tests/run_tests.sh # may fail PgDdlAtomicitySnapshotTest.SnapshotTest (has been flaky on master)

pg15_tests/run_tests.sh on test plan tests gives following results:

    0	2024-07-28T12:35:27-07:00	JAVA	org.yb.pgsql.TestPgRegressFeature#testPgRegressFeature
    1	2024-07-28T12:43:39-07:00	JAVA	org.yb.pgsql.TestPgTransparentRestarts#parallel
    0	2024-07-28T12:45:04-07:00	pgwrapper_pg_ddl_atomicity_stress-test	PgDdlAtomicityStressTest.BasicTest
    0	2024-07-28T12:46:30-07:00	pgwrapper_pg_ddl_atomicity_stress-test	PgDdlAtomicityStressTest.TestTxnVerificationFailure
    0	2024-07-28T12:48:02-07:00	pgwrapper_pg_ddl_atomicity_stress-test	PgDdlAtomicityStressTest.TestFailCatalogWrites
    0	2024-07-28T12:49:22-07:00	pgwrapper_pg_ddl_atomicity_stress-test	PgDdlAtomicityStressTest.TestFailDdlRollback
    0	2024-07-28T12:50:45-07:00	pgwrapper_pg_ddl_atomicity_stress-test	PgDdlAtomicityStressTest.TestFailDdlVerification
    0	2024-07-28T12:51:55-07:00	pgwrapper_pg_ddl_atomicity_stress-test	PgDdlAtomicityColocatedStressTest.BasicTest
    0	2024-07-28T12:53:13-07:00	pgwrapper_pg_ddl_atomicity_stress-test	PgDdlAtomicityColocatedStressTest.TestTxnVerificationFailure
    0	2024-07-28T12:54:29-07:00	pgwrapper_pg_ddl_atomicity_stress-test	PgDdlAtomicityColocatedStressTest.TestFailCatalogWrites
    0	2024-07-28T12:55:38-07:00	pgwrapper_pg_ddl_atomicity_stress-test	PgDdlAtomicityColocatedStressTest.TestFailDdlRollback
    0	2024-07-28T12:56:48-07:00	pgwrapper_pg_ddl_atomicity_stress-test	PgDdlAtomicityColocatedStressTest.TestFailDdlVerification
    0	2024-07-28T12:57:34-07:00	integration-tests_cdcsdk_consumption_consistent_changes-test	CDCSDKConsumptionConsistentChangesTest.TestIntentGC
    0	2024-07-28T12:57:52-07:00	integration-tests_cdcsdk_consumption_consistent_changes-test	CDCSDKConsumptionConsistentChangesTest.TestStreamExpiry
    0	2024-07-28T12:58:14-07:00	JAVA	org.yb.pgsql.TestPgAuthorization#testPgLocksAuthorization

org.yb.pgsql.TestPgTransparentRestarts#parallel fails on master as well.
Also:

    ./yb_build.sh fastdebug --gcc11 --enable-ysql-conn-mgr-test --java-test 'org.yb.pgsql.TestPgDropDatabase#testRecreateDatabase'
    ./yb_build.sh fastdebug --gcc11 --enable-ysql-conn-mgr-test --java-test 'org.yb.pgsql.TestDropTableWithConcurrentTxn#testDmlTxnDrop'
    ./yb_build.sh fastdebug --gcc11 --enable-ysql-conn-mgr-test --java-test 'org.yb.pgsql.TestDropTableWithConcurrentTxn#testDmlTxnDropWithReadCommitted'
    ./yb_build.sh fastdebug --gcc11 --enable-ysql-conn-mgr-test --java-test 'org.yb.pgsql.TestAlterTableWithConcurrentTxn#testDmlTransactionAfterAlterOnCurrentResourceWithCachedMetadata'

Jenkins: rebase: pg15

Reviewers: fizaa, tfoucher

Reviewed By: tfoucher

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D36882
pao214 added a commit that referenced this issue Jul 29, 2024
…PgAuthorization is run.

Summary:
Original commit: d4eeace / D36869
Role yb_db_admin_member is already created in testSessionAuthorization.
Need a newly named role for the testPgLocksAuthorization case.
Jira: DB-12216

Test Plan:
Jenkins

Jenkins will not catch this since this only manifests in a full run.

```
./yb_build.sh --java-test TestPgAuthorization
```

Backport-through: 2.20

Reviewers: jason

Reviewed By: jason

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D36895
pao214 added a commit that referenced this issue Jul 29, 2024
…stPgAuthorization is run.

Summary:
Original commit: d4eeace / D36869
Role yb_db_admin_member is already created in testSessionAuthorization.
Need a newly named role for the testPgLocksAuthorization case.
Jira: DB-12216

Test Plan:
Jenkins

Jenkins will not catch this since this only manifests in a full run.

```
./yb_build.sh --java-test TestPgAuthorization
```

Backport-through: 2.20

Reviewers: jason

Reviewed By: jason

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D36894
@pao214
Copy link
Contributor

pao214 commented Jul 29, 2024

Landed the change on master, 2024.1, and 2.20.

@pao214 pao214 closed this as completed Jul 29, 2024
jasonyb pushed a commit that referenced this issue Jul 31, 2024
Summary:
 80c02fc [#23296] xCluster: Skip BackfillMetadataForXRepl for SequencesSystemTable
 d4eeace [#23295] YSQL: Fix test failure when the whole of TestPgAuthorization is run.
 baf343f [#13358] YSQL: Fix bug in partitioned table DDL atomicity stress test
 7bf0eed [#23294] YSQL, ASH: Fix flaky test 'TestYbAsh#testEmptyCircularBuffer'
 17828e2 [PLAT-13286] Make ReprovisionNode task retryable
 34e6e7a [#23250] YSQL: UT org.yb.pgsql.TestPgMemoryGC#testPgMemoryGcOrderBy is failing with connection manager
 3104eb7 [PLAT-14204] Azure Provider - Allow the Resource Group for the Network to be overridden per Region.
 e27c3b9 [#18360] YSQL: Rework yb_hash_code comparision with an out of range constants
 2463ee0 [PLAT-14709] Fix DevSpace command for shared Kubernetes clusters

PgDdlAtomicityPartitionedTablesStressTest.* flaky fails with

```
[ts-1] 2024-07-30 15:46:42.577 UTC [16209] ERROR:  Restart read required at: { read: { days: 19934 time: 15:46:42.510692 } local_limit: { days: 19934 time: 15:46:42.510692 } global_limit: <min> in_txn_limit: <max> serial_no: 0 }
[ts-1] 2024-07-30 15:46:42.577 UTC [16209] CONTEXT:  Catalog Version Mismatch: A DDL occurred while processing this query. Try again.
[ts-1] 2024-07-30 15:46:42.577 UTC [16209] STATEMENT:  CREATE INDEX idx_0 ON test_table(key)
[ts-1] TRAP: FailedAssertion("entry->refcount == 1", File: "../../../../../../../src/postgres/src/backend/utils/cache/yb_inheritscache.c", Line: 337, PID: 16209)
[ts-1] postgres: postgres yugabyte 127.0.0.1(43848) CREATE INDEX(ExceptionalCondition+0x96)[0xb1f06d]
[ts-1] postgres: postgres yugabyte 127.0.0.1(43848) CREATE INDEX(YbPgInheritsCacheDelete+0x125)[0xaf8e4c]
[ts-1] postgres: postgres yugabyte 127.0.0.1(43848) CREATE INDEX(YbPgInheritsCacheInvalidate+0x88)[0xaf8f5f]
[ts-1] postgres: postgres yugabyte 127.0.0.1(43848) CREATE INDEX[0xaf90f7]
[ts-1] postgres: postgres yugabyte 127.0.0.1(43848) CREATE INDEX(InvalidateSystemCachesExtended+0x63)[0xafdd3c]
[ts-1] postgres: postgres yugabyte 127.0.0.1(43848) CREATE INDEX(CallSystemCacheCallbacks+0x13)[0xafddad]
[ts-1] postgres: postgres yugabyte 127.0.0.1(43848) CREATE INDEX[0x9a13fb]
[ts-1] postgres: postgres yugabyte 127.0.0.1(43848) CREATE INDEX(PostgresMain+0x66c)[0x9a8642]
[ts-1] postgres: postgres yugabyte 127.0.0.1(43848) CREATE INDEX[0x8e964d]
[ts-1] postgres: postgres yugabyte 127.0.0.1(43848) CREATE INDEX(PostmasterMain+0x1d74)[0x8ebca2]
[ts-1] postgres: postgres yugabyte 127.0.0.1(43848) CREATE INDEX(main+0x0)[0x81ed89]
[ts-1] postgres: postgres yugabyte 127.0.0.1(43848) CREATE INDEX(main+0x20)[0x81eda9]
[ts-1] /lib64/libc.so.6(__libc_start_main+0xe5)[0x7f1a00fcd7e5]
[ts-1] postgres: postgres yugabyte 127.0.0.1(43848) CREATE INDEX(_start+0x2e)[0x4bbdfe]
```

Test Plan: Jenkins: rebase: pg15-cherrypicks

Reviewers: jason, tfoucher

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D36922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ysql Yugabyte SQL (YSQL) kind/enhancement This is an enhancement of an existing feature kind/failing-test Tests and testing infra priority/medium Medium priority issue status/awaiting-triage Issue awaiting triage
Projects
None yet
Development

No branches or pull requests

4 participants