Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDCSDK] Support for Dynamic Type in Logical Replication (UDT, Hstore, Enum array, Extension types) #23240

Closed
yugabyte-ci opened this issue Jul 18, 2024 · 0 comments
Assignees
Labels
area/cdcsdk CDC SDK jira-originated kind/new-feature This is a request for a completely new feature priority/high High Priority

Comments

@yugabyte-ci
Copy link
Contributor

yugabyte-ci commented Jul 18, 2024

Jira Link: DB-12173

@yugabyte-ci yugabyte-ci added area/cdcsdk CDC SDK jira-originated kind/new-feature This is a request for a completely new feature priority/high High Priority labels Jul 18, 2024
@yugabyte-ci yugabyte-ci changed the title [CDCSDK] Support for Dynamic Type in Logical Replication (UDT,HSTORE,ARRAY[ENUM]) [CDCSDK] Support for Dynamic Type in Logical Replication (UDT, Hstore, Enum array, Extension types) Jul 18, 2024
Sumukh-Phalgaonkar added a commit that referenced this issue Jul 23, 2024
…es more resilient

Summary:
In the tests `TestPgReplicationSlot#replicationConnectionConsumptionAllDataTypesWithYbOutput` and `TestPgReplicationSlot#replicationConnectionConsumptionAllDataTypesWithPgOutput` we create a table with dynamic types. This means that the typeoid of such types is allocated at runtime. The tests assert on the relation message to check the type_oid of every column. This makes the tests fragile as any change in the Oids allotment will cause the test to fail.

This diff makes these tests more robust by skipping the type_oid assertions for dynamic types.
Jira: DB-12173

Test Plan: Jenkins: .*TestPgReplicationSlot.*

Reviewers: siddharth.shah, stiwary

Reviewed By: siddharth.shah

Subscribers: ycdcxcluster

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D36763
jasonyb pushed a commit that referenced this issue Jul 23, 2024
Summary:
5a76f6a [#23179] CDCSDK: Support data types with dynamically alloted oids in CDC
5820ccd [PLAT-14710] Do not return apiToken in response to getSessionInfo
dcfa9cd [docs] updates to CVE table status column (#23225)
c0b1ee8 [docs] Fix load balance keyword in drivers page (#23253)
2becb46 [docs] Add basic troubleshooting steps for read restart errors. (#23228)
1b9be2e [PLAT-12733] Kubernetes overrides in v2 api
50422f8 [#23011] YSQL: Enable ALTER TABLE IF EXISTS t RENAME c1 TO c2
7c55b95 [PLAT-14073] DB scoped failover+repair
5ac65eb [#22449] YSQL: import wal2json wal2json_2_6
9e046fb [#23163] YSQL: pg_partman: make 'inherit_template_properties' idempotent
2248dcd [#23163] YSQL: pg_partman: make 'apply_publications' idempotent
7b32d05 [#23163] YSQL: pg_partman: Make partition creation idempotent
b0349fe [PLAT-14710] update api doc for /session_info
fe37ffd [#23240] CDCSDK: Make test replicationConnectionConsumptionAllDataTypes more resilient

Test Plan: Jenkins: rebase: pg15-cherrypicks

Reviewers: tfoucher

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D36789
Sumukh-Phalgaonkar added a commit that referenced this issue Jul 25, 2024
…umptionAllDataTypes more resilient

Summary:
######Backport Description
No merge conflicts were encountered.

######Original Description
In the tests `TestPgReplicationSlot#replicationConnectionConsumptionAllDataTypesWithYbOutput` and `TestPgReplicationSlot#replicationConnectionConsumptionAllDataTypesWithPgOutput` we create a table with dynamic types. This means that the typeoid of such types is allocated at runtime. The tests assert on the relation message to check the type_oid of every column. This makes the tests fragile as any change in the Oids allotment will cause the test to fail.

This diff makes these tests more robust by skipping the type_oid assertions for dynamic types.
Jira: DB-12173

Original commit: fe37ffd / D36763

Test Plan: Jenkins: .*TestPgReplicationSlot.*

Reviewers: siddharth.shah, stiwary

Reviewed By: siddharth.shah

Subscribers: ycdcxcluster

Tags: #jenkins-ready

Differential Revision: https://phorge.dev.yugabyte.com/D36773
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cdcsdk CDC SDK jira-originated kind/new-feature This is a request for a completely new feature priority/high High Priority
Projects
None yet
Development

No branches or pull requests

2 participants